Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fix TabbedPage appearing when inside other PageContainer #4309

Merged
merged 3 commits into from Nov 9, 2018

Conversation

@rmarinho
Copy link
Member

commented Nov 5, 2018

Description of Change

Check if we are inside a PageContainer , if we are the PageContainer will handle fire SendAppearing

Issues Resolved

API Changes

None

Platforms Affected

  • Android

Behavioral/Visual Changes

Appearing should not fire by default when attached to window when a TabbedPage is inside other TabbedPage.

Before/After Screenshots

Not applicable

Testing Procedure

Navigate to issue4303 on the gallery,
Check if as Success when opening the page , then navigate to Tab 4 to see if it also shows Success.

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard
rmarinho added 2 commits Nov 5, 2018

@PureWeen PureWeen requested review from hartez and kingces95 Nov 5, 2018

@PureWeen PureWeen added this to In Review in v3.6.0 Nov 6, 2018

@hartez
hartez approved these changes Nov 6, 2018

@rmarinho rmarinho merged commit c3f5f1b into master Nov 9, 2018

9 of 10 checks passed

VSTS: iOS10 Validation UITests Finished
Details
VSTS: Android API19 Validation Fast Renderers UITests Finished
Details
VSTS: Android API19 Validation Legacy Renderers UITests Finished
Details
VSTS: Android API23 Validation Fast Renderers UITests Finished
Details
VSTS: Android API23 Validation Legacy Renderers UITests Finished
Details
VSTS: Android API25 Validation Fast Renderers UITests Finished
Details
VSTS: Android API25 Validation Legacy Renderers UITests Finished
Details
VSTS: iOS11 Validation UITests Finished
Details
Xamarin Forms #PR-4309 - (2194518) succeeded
Details
license/cla All CLA requirements met.
Details

v3.6.0 automation moved this from In Review to Done Nov 9, 2018

@hartez hartez deleted the fix-4303 branch Nov 14, 2018

@samhouts samhouts added this to the 4.0.0 milestone Dec 4, 2018

@samhouts samhouts removed this from Done in v3.6.0 Jan 3, 2019

@samhouts samhouts modified the milestones: 4.0.0, 3.5.0 Jan 10, 2019

@samhouts samhouts added this to Done in v3.5.0 Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
5 participants
You can’t perform that action at this time.