Ignore null context change on UAP #4412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jassmith
approved these changes
Nov 15, 2018
paymicro
reviewed
Dec 4, 2018
| @@ -161,6 +161,9 @@ void OnContextActionsChanged(object sender, NotifyCollectionChangedEventArgs e) | |||
|
|
|||
| void OnDataContextChanged(FrameworkElement sender, DataContextChangedEventArgs args) | |||
| { | |||
| if (args.NewValue == null) | |||
There was a problem hiding this comment.
Maybe below delete the check args.NewValue != null?
rmarinho
approved these changes
Dec 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
If you set ListView ItemTemplate property to custom DataTemplateSelector, then while scrolling overridden OnSelectTemplate method will be called with item argument equal to null.
Unable to reproduce issue on Android. It seems that returning null when item == null does not affect ListView elements and everything works as expected.
Issues Resolved
Platforms Affected
Behavioral/Visual Changes
None
Testing Procedure
See bug
PR Checklist