Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Remove WebViewRenderer dependency on Activity #4428

Merged
merged 2 commits into from Nov 21, 2018

Conversation

@rmarinho
Copy link
Member

commented Nov 15, 2018

Description of Change

The context is not always an Activity, for example running on the Previewer. Remove the Exception , handle fail gracefully with a Log warning

Issues Resolved

API Changes

none

None

Platforms Affected

  • Android

Behavioral/Visual Changes

IF running in the previewer you won't be able to open alerts or the file picker for a WebView.

Before/After Screenshots

Not applicable

Testing Procedure

Check if the previewer doesn't crash in a Xaml page with a

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard

VS bug #730672

@rmarinho rmarinho added this to In progress in Sprint 144 via automation Nov 15, 2018

@rmarinho rmarinho moved this from In progress to Ready for Review (Issues) in Sprint 144 Nov 15, 2018

@rmarinho rmarinho moved this from Ready for Review (Issues) to Ready for Review (PRs) in Sprint 144 Nov 15, 2018

@hartez hartez requested review from jassmith and kingces95 Nov 15, 2018

@samhouts samhouts added this to In Review in v3.6.0 Nov 19, 2018

@samhouts samhouts added the approved label Nov 20, 2018

@rmarinho rmarinho merged commit 11e5790 into master Nov 21, 2018

10 checks passed

VSTS: Android API19 Validation Fast Renderers UITests Finished
Details
VSTS: Android API19 Validation Legacy Renderers UITests Finished
Details
VSTS: Android API23 Validation Fast Renderers UITests Finished
Details
VSTS: Android API23 Validation Legacy Renderers UITests Finished
Details
VSTS: Android API25 Validation Fast Renderers UITests Finished
Details
VSTS: Android API25 Validation Legacy Renderers UITests Finished
Details
VSTS: iOS10 Validation UITests Finished
Details
VSTS: iOS11 Validation UITests Finished
Details
Xamarin Forms #PR-4428 - (2211500) succeeded
Details
license/cla All CLA requirements met.
Details

v3.6.0 automation moved this from In Review to Done Nov 21, 2018

Sprint 144 automation moved this from Ready for Review (PRs) to Done Nov 21, 2018

@rmarinho rmarinho deleted the fix-4107 branch Nov 21, 2018

@samhouts samhouts added this to Done in v4.0.0 Feb 2, 2019

@samhouts samhouts removed this from Done in v3.6.0 Feb 2, 2019

@samhouts samhouts added this to Done in v4.1.0 Mar 2, 2019

@samhouts samhouts removed this from Done in v4.0.0 Mar 2, 2019

@samhouts samhouts added this to Done in vCurrent (4.2.0) May 29, 2019

@samhouts samhouts removed this from Done in v4.1.0 May 29, 2019

@samhouts samhouts added the i/critical label Jul 2, 2019

@samhouts samhouts removed this from Done in vCurrent (4.2.0) Jul 4, 2019

@samhouts samhouts added this to Done in vNext (4.3.0) Jul 8, 2019

@samhouts samhouts added this to the 3.5.0 milestone Aug 1, 2019

@samhouts samhouts removed this from Done in vNext (4.3.0) Sep 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4 participants
You can’t perform that action at this time.