Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C] perf fixes on BindingExpression.TryConvert #4443

Merged
merged 1 commit into from Nov 16, 2018

Conversation

@StephaneDelcroix
Copy link
Member

commented Nov 16, 2018

Description of Change

BindingExpression.TryConvert is a hot path, the string operation should
use the StringComparison. Also (less hot as it's a fallback), we should
avoid throwing for catching the exception a few line later.

Issues Resolved

N/A

API Changes

None

Platforms Affected

  • Core/XAML (all platforms)
  • iOS
  • Android
  • UWP

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard
[C] perf fixes on BindingExpression.TryConvert
BindingExpression.TryConvert is a hot path, the string operation should
use the StringComparison. Also (less hot as it's a fallback), we should
avoid throwing for catching the exception a few line later.

@hartez hartez requested review from hartez and jassmith Nov 16, 2018

@hartez
hartez approved these changes Nov 16, 2018

@jassmith jassmith merged commit 2fd438d into master Nov 16, 2018

2 checks passed

Xamarin Forms #PR-4443 - (2215087) succeeded
Details
license/cla All CLA requirements met.

@samhouts samhouts added this to Done in v3.6.0 Nov 19, 2018

@StephaneDelcroix StephaneDelcroix deleted the bindingfixes branch Dec 19, 2018

@samhouts samhouts added this to Done in v4.0.0 Feb 2, 2019

@samhouts samhouts removed this from Done in v3.6.0 Feb 2, 2019

@samhouts samhouts added this to Done in v4.1.0 Mar 2, 2019

@samhouts samhouts removed this from Done in v4.0.0 Mar 2, 2019

@samhouts samhouts added this to Done in vCurrent (4.2.0) May 29, 2019

@samhouts samhouts removed this from Done in v4.1.0 May 29, 2019

@samhouts samhouts removed this from Done in vCurrent (4.2.0) Jul 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.