Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XamlC] Port #1035 to compiled bindings #4454

Merged
merged 1 commit into from Nov 20, 2018

Conversation

@StephaneDelcroix
Copy link
Member

commented Nov 18, 2018

Description of Change

[XamlC] Port #1035 to comiled bindings
And share the TryConvert implementation to avoid future diverges

Issues Resolved

/

API Changes

None

Platforms Affected

  • Core/XAML (all platforms)

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard
[XamlC] Port #1035 to comiled bindings
And share the TryConvert implementation to avoid future diverges

@StephaneDelcroix StephaneDelcroix changed the title [XamlC] Port #1035 to comiled bindings [XamlC] Port #1035 to compiled bindings Nov 19, 2018

@hartez
hartez approved these changes Nov 19, 2018

@hartez hartez requested a review from samhouts Nov 19, 2018

@samhouts samhouts added this to In Review in v3.6.0 Nov 19, 2018

@samhouts samhouts merged commit 4f789b9 into master Nov 20, 2018

2 checks passed

Xamarin Forms #PR-4454 - (2219080) succeeded
Details
license/cla All CLA requirements met.
Details

v3.6.0 automation moved this from In Review to Done Nov 20, 2018

@samhouts samhouts deleted the compBindings1035 branch Nov 20, 2018

@samhouts samhouts added this to the 4.0.0 milestone Dec 4, 2018

@samhouts samhouts removed this from Done in v3.6.0 Jan 3, 2019

@samhouts samhouts modified the milestones: 4.0.0, 3.5.0 Jan 10, 2019

@samhouts samhouts added this to Done in v3.5.0 Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.