New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified type cast to appropriate type #447

Merged
merged 1 commit into from Oct 12, 2016

Conversation

Projects
None yet
5 participants
@ckrempp91
Contributor

ckrempp91 commented Oct 11, 2016

Description of Change

I changed the type cast from BitmapImage to BitmapSource because if you want to do image manipulation, in UWP, you use the WriteableBitmap class.

Bugs Fixed

This fixes the InvalidCastException which can result in the app crashing

API Changes

None

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
Modified type cast to appropriate type
I changed the type cast from BitmapImage to BitmapSource because if you want to do image manipulation, in UWP, you use the WriteableBitmap class.
@dnfclas

This comment has been minimized.

Show comment
Hide comment
@dnfclas

dnfclas Oct 11, 2016

Hi @ckrempp91, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

dnfclas commented Oct 11, 2016

Hi @ckrempp91, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

@rmarinho rmarinho merged commit 36d9dce into xamarin:master Oct 12, 2016

@samhouts samhouts added this to the 2.3.4 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment