Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C] Fix check for CollectionView flag #4471

Merged
merged 1 commit into from Nov 19, 2018

Conversation

@StephaneDelcroix
Copy link
Member

commented Nov 19, 2018

Description of Change

If Device.Flags is null, the code supposed to check for the presence of
the flags throws a NullReferenceException. Most users will get that
instead of the helpful version of it. Which is not very inclusive of the
people too lazy to read the docs.

Issues Resolved

None

API Changes

None

Platforms Affected

  • Core/XAML (all platforms)

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard
[C] Fix check for CollectionView flag
If Device.Flags is null, the code supposed to check for the presence of
the flags throws a NullReferenceException. Most users will get that
instead of the helpful version of it. Which is not very inclusive of the
people too lazy to read the docs.
@hartez
hartez approved these changes Nov 19, 2018

@hartez hartez requested a review from samhouts Nov 19, 2018

@PureWeen
Copy link
Contributor

left a comment

I made this same change in my visual PR and it fixed the NRE for me

@PureWeen PureWeen assigned PureWeen and unassigned samhouts Nov 19, 2018

@PureWeen PureWeen removed the request for review from samhouts Nov 19, 2018

@samhouts samhouts added this to In Review in v3.6.0 Nov 19, 2018

@hartez hartez merged commit 4871781 into master Nov 19, 2018

2 checks passed

Xamarin Forms #PR-4471 - (2220411) succeeded
Details
license/cla All CLA requirements met.

v3.6.0 automation moved this from In Review to Done Nov 19, 2018

@samhouts samhouts added this to the 4.0.0 milestone Dec 4, 2018

@StephaneDelcroix StephaneDelcroix deleted the cvflags branch Dec 19, 2018

@samhouts samhouts removed this from Done in v3.6.0 Jan 3, 2019

@samhouts samhouts modified the milestones: 4.0.0, 3.5.0 Jan 10, 2019

@samhouts samhouts added this to Done in v3.5.0 Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4 participants
You can’t perform that action at this time.