Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS,Android] Handle Appearing/Disappearing on CarouselPage #4475

Merged
merged 3 commits into from Nov 27, 2018

Conversation

@rmarinho
Copy link
Member

commented Nov 19, 2018

Description of Change

Handling appearing and dissapearing of CarouselPage

Issues Resolved

API Changes

None

Platforms Affected

  • iOS
  • Android

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard
rmarinho added 3 commits Nov 19, 2018

@samhouts samhouts added this to In Review in v3.6.0 Nov 19, 2018

@samhouts samhouts added this to Ready for Review (PRs) in Sprint 144 Nov 19, 2018

@hartez hartez requested a review from kingces95 Nov 20, 2018

@kingces95 kingces95 merged commit 6f76390 into master Nov 27, 2018

10 checks passed

VSTS: Android API19 Validation Fast Renderers UITests Finished
Details
VSTS: Android API19 Validation Legacy Renderers UITests Finished
Details
VSTS: Android API23 Validation Fast Renderers UITests Finished
Details
VSTS: Android API23 Validation Legacy Renderers UITests Finished
Details
VSTS: Android API25 Validation Fast Renderers UITests Finished
Details
VSTS: Android API25 Validation Legacy Renderers UITests Finished
Details
VSTS: iOS10 Validation UITests Finished
Details
VSTS: iOS11 Validation UITests Finished
Details
Xamarin Forms #PR-4475 - (2220919) succeeded
Details
license/cla All CLA requirements met.
Details

v3.6.0 automation moved this from In Review to Done Nov 27, 2018

@samhouts samhouts added the approved label Nov 27, 2018

@samhouts samhouts added this to In progress in Sprint 145 Nov 28, 2018

@samhouts samhouts moved this from In progress to Done in Sprint 145 Nov 28, 2018

@samhouts samhouts added this to the 4.0.0 milestone Dec 4, 2018

@StephaneDelcroix StephaneDelcroix deleted the fix-2951 branch Dec 19, 2018

@samhouts samhouts removed this from Done in v3.6.0 Jan 3, 2019

@samhouts samhouts modified the milestones: 4.0.0, 3.5.0 Jan 10, 2019

@samhouts samhouts added this to Done in v3.5.0 Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.