Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xaml] OnIdiomMarkupExt uses converters on BPs #4500

Merged
merged 1 commit into from Nov 22, 2018

Conversation

@StephaneDelcroix
Copy link
Member

commented Nov 21, 2018

Description of Change

Up to now, OnPlatform and OnIdiom markup extensions were checking for
type converters on

  • target type
  • the property being set

in case of a bindable property, the converter on the BP getter or
GetBP() static method (for attached BPs) wasn't checked.

This PR adds the check for that, plus a unit test.

Issues Resolved

API Changes

None

Platforms Affected

  • Core/XAML (all platforms)

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard
[Xaml] OnIdiomMarkupExt uses converters on BPs
Up to now, OnPlatform and OnIdiom markup extensions were checking for
type converters on
- target type
- the property being set

in case of a bindable property, the converter on the BP getter or
GetBP() static method (for attached BPs) wasn't checked.

This PR adds the check for that, plus a unit test.

- fixes #4319

@hartez hartez requested review from hartez and samhouts Nov 21, 2018

@samhouts samhouts added this to In Review in v3.6.0 Nov 21, 2018

@hartez
Copy link
Member

left a comment

Looks good, just wondering if we need a second test.

@@ -0,0 +1,12 @@
<?xml version="1.0" encoding="UTF-8"?>

This comment has been minimized.

Copy link
@hartez

hartez Nov 21, 2018

Member

Should there also be a unit test for this with OnIdiom? Or is that covered elsewhere?

@samhouts samhouts moved this from In Review to In Progress in v3.6.0 Nov 22, 2018

@StephaneDelcroix StephaneDelcroix merged commit d0456e2 into master Nov 22, 2018

2 checks passed

Xamarin Forms #PR-4500 - (2226915) succeeded
Details
license/cla All CLA requirements met.
Details

v3.6.0 automation moved this from In Progress to Done Nov 22, 2018

@StephaneDelcroix StephaneDelcroix deleted the fix_gh4319 branch Nov 22, 2018

@samhouts samhouts added this to the 4.0.0 milestone Dec 4, 2018

@samhouts samhouts removed this from Done in v3.6.0 Jan 3, 2019

@samhouts samhouts modified the milestones: 4.0.0, 3.5.0 Jan 10, 2019

@samhouts samhouts added this to Done in v3.5.0 Jan 11, 2019

@samhouts samhouts added the t/bug 🐛 label Jun 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.