Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] set image to null when view is disposed #4507

Merged
merged 1 commit into from Nov 22, 2018

Conversation

@PureWeen
Copy link
Contributor

commented Nov 21, 2018

Description of Change

Set the ImageViews drawable to null otherwise when the view is removed it tries to recreate the imageview because of leaks

Issues Resolved

Platforms Affected

  • Android

Testing Procedure

Run the added UI Test (4484) and rotate the device a bunch

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard

@samhouts samhouts added this to In Review in v3.6.0 Nov 22, 2018

@PureWeen

This comment has been minimized.

Copy link
Contributor Author

commented Nov 22, 2018

iOS test failure is unrelated

@rmarinho rmarinho merged commit 52c8fe0 into master Nov 22, 2018

9 of 10 checks passed

VSTS: iOS10 Validation UITests Finished
Details
VSTS: Android API19 Validation Fast Renderers UITests Finished
Details
VSTS: Android API19 Validation Legacy Renderers UITests Finished
Details
VSTS: Android API23 Validation Fast Renderers UITests Finished
Details
VSTS: Android API23 Validation Legacy Renderers UITests Finished
Details
VSTS: Android API25 Validation Fast Renderers UITests Finished
Details
VSTS: Android API25 Validation Legacy Renderers UITests Finished
Details
VSTS: iOS11 Validation UITests Finished
Details
Xamarin Forms #PR-4507 - (2228096) succeeded
Details
license/cla All CLA requirements met.
Details

v3.6.0 automation moved this from In Review to Done Nov 22, 2018

@samhouts samhouts added this to the 4.0.0 milestone Dec 4, 2018

@StephaneDelcroix StephaneDelcroix deleted the gh4484 branch Dec 19, 2018

@samhouts samhouts removed this from Done in v3.6.0 Jan 3, 2019

@samhouts samhouts modified the milestones: 4.0.0, 3.5.0 Jan 10, 2019

@samhouts samhouts added this to Done in v3.5.0 Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4 participants
You can’t perform that action at this time.