Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UWP] fixes control render by ViewToRendererConverter in off screen #4532

Merged
merged 1 commit into from Nov 28, 2018

Conversation

@paymicro
Copy link
Collaborator

commented Nov 26, 2018

Description of Change

If a control rendered by ViewToRendererConverter is off the screen sizes of the control could be negative, which caused an error. To avoid exception a control don't call Arrage and the panel becomes completely transparent.

Issues Resolved

API Changes

None

Platforms Affected

  • UWP

Behavioral/Visual Changes

When you change the width of the TitleView, the width of the control automatically changes.

Before/After Screenshots

Not applicable

Testing Procedure

  • Go to Navigation Control Gallery (Legacy) which should render a searchbar in the header
  • Size the window down horizontally so that the SearchBar is no longer in view
  • Сrash should not be

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard
@StephaneDelcroix
Copy link
Member

left a comment

looks good. make sure we do not mess up with user-provided opacity

@samhouts samhouts added this to In Review in v3.6.0 Nov 26, 2018

@rmarinho rmarinho merged commit 2f6c6ec into xamarin:master Nov 28, 2018

2 checks passed

Xamarin Forms #PR-4532 - (2233311) succeeded
Details
license/cla All CLA requirements met.
Details

v3.6.0 automation moved this from In Review to Done Nov 28, 2018

@samhouts samhouts added this to the 4.0.0 milestone Dec 4, 2018

@samhouts samhouts removed this from Done in v3.6.0 Jan 3, 2019

@samhouts samhouts modified the milestones: 4.0.0, 3.5.0 Jan 10, 2019

@samhouts samhouts added this to Done in v3.5.0 Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4 participants
You can’t perform that action at this time.