New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable using EstimatedRowHeight for uneven rows with known heights #454

Merged
merged 1 commit into from Dec 13, 2016

Conversation

Projects
None yet
6 participants
@hartez
Member

hartez commented Oct 13, 2016

Description of Change

Modifies the ListViewRenderer and UnevenListViewDataSource to return an estimated row height of zero when the cell heights are known. This prevents iOS from attempting to use row height estimates unnecessarily, which causes scrolling issues (especially if the specified cell heights are very different from the minimum measured cell heights).

There are tests for both estimated row height and known row height, but they are not automated (nothing in the UI test platform for detecting this sort of thing).

Bugs Fixed

API Changes

None

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@adrianknight89

This comment has been minimized.

Show comment
Hide comment
@adrianknight89

adrianknight89 Dec 9, 2016

Contributor

@hartez @rmarinho There is a memory leak with EditorRenderer where event handlers seem to be registered more times than the number of view cells when each cell has an Editor. Can we see this and #524 in master soon so I could work off of them?

Contributor

adrianknight89 commented Dec 9, 2016

@hartez @rmarinho There is a memory leak with EditorRenderer where event handlers seem to be registered more times than the number of view cells when each cell has an Editor. Can we see this and #524 in master soon so I could work off of them?

@hartez hartez requested a review from jassmith Dec 12, 2016

@jassmith jassmith merged commit 5ad5752 into master Dec 13, 2016

6 checks passed

Android-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Tests passed: 350, i…
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: Windows Debug : Tests passed: 3679, ignored: 10
Details
iOS10-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Tests passed: 34…
Details
iOS8-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified IOS8 : Tests passed: 344…
Details
iOS9-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Tests passed: 346…
Details

@rmarinho rmarinho deleted the fix-bugzilla43313 branch Mar 22, 2017

@samhouts samhouts referenced this pull request Mar 24, 2017

Merged

[iOS] Don't skip row height estimation for grouped lists #838

4 of 4 tasks complete

@samhouts samhouts added this to the 2.3.4 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment