Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] ItemContentView should use all available space #4569

Merged
merged 3 commits into from Dec 11, 2018

Conversation

@hartez
Copy link
Member

commented Nov 28, 2018

Description of Change

ItemContentView should take up the available space given to it by the layout manager.
Also fixes some inconsistent/inaccurate class naming for cells/views.

Issues Resolved

API Changes

None

Platforms Affected

  • Android

Behavioral/Visual Changes

CollectionView items on Android now layout like they do on iOS.

Before/After Screenshots

Before:
screenshot_1543363225

After:
screenshot_1543422703

Testing Procedure

Navigate to Control Gallery -> CollectionView Gallery -> DataTemplate Galleries -> Vertical List (Code); if the items are centered, the test has passed. If they are left-aligned, the test has failed.

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard
[Android] ItemContentView should use all available space; fixes #4406
Fix inconsistent/inaccurate class naming for cells/views.

@samhouts samhouts added the e/5 🕔 label Nov 28, 2018

@samhouts samhouts added this to In Review in v3.6.0 Nov 28, 2018

@samhouts samhouts added this to Ready for Review (PRs) in Sprint 145 Nov 28, 2018

@samhouts samhouts requested a review from PureWeen Nov 29, 2018

@samhouts samhouts requested a review from mattleibow Nov 29, 2018

mattleibow and others added 2 commits Nov 29, 2018
Update Xamarin.Forms.Platform.Android/CollectionView/SizedItemContent…
…View.cs


Add missing space.

Co-Authored-By: hartez <hartez@users.noreply.github.com>

@samhouts samhouts modified the milestone: 3.5.0 Dec 4, 2018

@hartez hartez changed the base branch from master to 3.5.0 Dec 5, 2018

@samhouts samhouts removed this from In Review in v3.6.0 Dec 6, 2018

@samhouts samhouts added this to In Review in v3.5.0 Dec 6, 2018

@samhouts samhouts removed the request for review from PureWeen Dec 11, 2018

@samhouts samhouts assigned rmarinho and unassigned PureWeen Dec 11, 2018

@mattleibow
Copy link
Contributor

left a comment

LGTM

@rmarinho rmarinho merged commit 154c2d0 into 3.5.0 Dec 11, 2018

2 checks passed

Xamarin Forms #PR-4569 - (2243420) succeeded
Details
license/cla All CLA requirements met.
Details

v3.5.0 automation moved this from In Review to Done Dec 11, 2018

Sprint 145 automation moved this from Ready for Review (PRs) to Done Dec 11, 2018

@mattleibow mattleibow deleted the fix-gh4406 branch Dec 12, 2018

rotorgames added a commit to rotorgames/Xamarin.Forms that referenced this pull request Dec 23, 2018
[Android] ItemContentView should use all available space (xamarin#4569)
fixes xamarin#4406

* [Android] ItemContentView should use all available space; fixes xamarin#4406
Fix inconsistent/inaccurate class naming for cells/views.

* Update Xamarin.Forms.Platform.Android/CollectionView/SizedItemContentView.cs

Add missing space.

Co-Authored-By: hartez <hartez@users.noreply.github.com>

* Make ReuseId values match class names

# Conflicts:
#	Xamarin.Forms.Platform.Android/CollectionView/CarouselViewRenderer.cs
#	Xamarin.Forms.Platform.Android/CollectionView/ItemContentControl.cs
#	Xamarin.Forms.Platform.Android/CollectionView/SizedItemContentControl.cs
#	Xamarin.Forms.Platform.Android/Xamarin.Forms.Platform.Android.csproj
#	Xamarin.Forms.Platform.iOS/Xamarin.Forms.Platform.iOS.csproj

@samhouts samhouts added this to the 3.5.0 milestone Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.