Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shell][iOS] do not try to smartly unblend bgcolor #4593

Merged
merged 1 commit into from Dec 4, 2018

Conversation

@StephaneDelcroix
Copy link
Member

commented Nov 30, 2018

Description of Change

Unblending bg color was a smart idea. But only works in a controlled
subset of cases. To avoid unexpected blends, we will do the dumb stuff,
as we always do.

Issues Resolved

/

API Changes

None

Platforms Affected

  • iOS

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard
[Shell][iOS] do not try to smartly unblend bgcolor
Unblending bg color was a smart idea. But only works in a controlled
subset of cases. To avoid unexpected blends, we will do the dumb stuff,
as we always do.

@samhouts samhouts added the e/1 🕐 label Nov 30, 2018

@samhouts samhouts added this to In Review in v3.5.0 Nov 30, 2018

@samhouts samhouts added this to In progress in Sprint 145 Nov 30, 2018

@samhouts samhouts requested review from mattleibow and paymicro Dec 3, 2018

Sprint 145 automation moved this from In progress to Ready for Review (PRs) Dec 3, 2018

@mattleibow
Copy link
Contributor

left a comment

LGTM.

One thing is that I am not sure in what cases the simple/default logic looked bad. Also, what is going to happen to existing apps?

But, I am all for not trying to be clever, so this is a good thing.

@rmarinho rmarinho merged commit f4fa789 into 3.5.0 Dec 4, 2018

2 checks passed

Xamarin Forms #PR-4593 - (2244783) succeeded
Details
license/cla All CLA requirements met.
Details

v3.5.0 automation moved this from In Review to Done Dec 4, 2018

Sprint 145 automation moved this from Ready for Review (PRs) to Done Dec 4, 2018

@StephaneDelcroix StephaneDelcroix deleted the reblend branch Dec 19, 2018

@samhouts samhouts added this to the 3.5.0 milestone Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.