Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shell] allow missing trailing slash on uri #4595

Merged
merged 1 commit into from Dec 3, 2018

Conversation

@StephaneDelcroix
Copy link
Member

commented Nov 30, 2018

Description of Change

do not crash anymore while navigation to app:///home/foo (without a trailing slash)

Issues Resolved

/

API Changes

None

Platforms Affected

  • Core/XAML (all platforms)

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard

@samhouts samhouts added the e/2 🕑 label Nov 30, 2018

@samhouts samhouts added this to In Review in v3.5.0 Nov 30, 2018

@samhouts samhouts added this to In progress in Sprint 145 Nov 30, 2018

Sprint 145 automation moved this from In progress to Ready for Review (PRs) Dec 3, 2018

@rmarinho

This comment has been minimized.

Copy link
Member

commented Dec 3, 2018

Do you think we could add a Unit test?

@PureWeen
Copy link
Contributor

left a comment

Tested with David's shell app and looks to work.

Only suggestion would be to change the text

Navigation: Current location doesn't match navigation uri /root/items/ != /root/items/ad/

I realize it's thrown inside "Navigated" but users are going to see this error when they are "Navigating" so the text Current location is a bit confusing.

Something like this seems a bit more informative

Navigation Failed from  /root/items/ to  /root/items/ad/ 
@StephaneDelcroix StephaneDelcroix referenced this pull request Dec 3, 2018
2 of 3 tasks complete

@StephaneDelcroix StephaneDelcroix merged commit 75887f6 into 3.5.0 Dec 3, 2018

2 checks passed

Xamarin Forms #PR-4595 - (2244840) succeeded
Details
license/cla All CLA requirements met.

v3.5.0 automation moved this from In Review to Done Dec 3, 2018

Sprint 145 automation moved this from Ready for Review (PRs) to Done Dec 3, 2018

@StephaneDelcroix StephaneDelcroix deleted the shell-trailingslash branch Dec 3, 2018

@samhouts samhouts added this to the 4.0.0 milestone Dec 4, 2018

@samhouts samhouts removed this from Done in v3.5.0 Dec 4, 2018

@samhouts samhouts modified the milestones: 4.0.0, 3.5.0 Jan 10, 2019

@samhouts samhouts added this to Done in v3.5.0 Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4 participants
You can’t perform that action at this time.