Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tasks] avoid passing dupe assemblies to Cecil #4624

Merged
merged 2 commits into from Dec 4, 2018

Conversation

@StephaneDelcroix
Copy link
Member

commented Dec 4, 2018

Description of Change

avoid feeding Mono.Cecil with dupes. Removes a negligeable handful
of milliseconds (100ms on average, hard to measure) from XamlC. Even
less from XamlG.

Issues Resolved

API Changes

None

Platforms Affected

  • Build

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard
[tasks] avoid passing dupe assemblies to Cecil
avoid feeding Mono.Cecil with dupes. Removes a negligeable handful
of milliseconds (100ms on average, hard to measure) from XamlC. Even
less from XamlG.

- fixes #4620

@rmarinho rmarinho merged commit f330652 into 3.5.0 Dec 4, 2018

2 checks passed

Xamarin Forms #PR-4624 - (2252361) succeeded
Details
license/cla All CLA requirements met.
Details

@samhouts samhouts added this to Done in v3.5.0 Dec 4, 2018

@samhouts samhouts added the e/1 🕐 label Dec 14, 2018

@StephaneDelcroix StephaneDelcroix deleted the fix_gh4620 branch Dec 19, 2018

@samhouts samhouts added this to the 3.5.0 milestone Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4 participants
You can’t perform that action at this time.