This repository was archived by the owner on May 1, 2024. It is now read-only.
[UWP] Fixes IsTabStop property in Layouts #4703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
reviewed
Dec 17, 2018
mattleibow
approved these changes
Dec 21, 2018
kingces95
approved these changes
Jan 18, 2019
Contributor
|
build |
andreinitescu
pushed a commit
to andreinitescu/Xamarin.Forms
that referenced
this pull request
Jan 29, 2019
* [UWP] the ScrollView does not gain focus * address comments fixes xamarin#4653
|
@paymicro can this be redone? It's causing a scrollview bug. There are two tags that are implemented via interfaces. (Is this a code smell?). ITabStopOnDescendants: StepperRenderer, TimePickerRenderer, DatePickerRenderer, SearchBarRenderer Since the bug found is in ScrollViewRenderer it seems that we can remove the IDontGetFocus tag from ScrollViewRenderer. Then IDontGetFocus and ITabStopOnDescendants can be merged. Does this interfere with the intention of this PR? cc @AxelUser |
AxelUser
pushed a commit
to AxelUser/Xamarin.Forms
that referenced
this pull request
Jun 9, 2019
3 tasks
AxelUser
pushed a commit
to AxelUser/Xamarin.Forms
that referenced
this pull request
Jun 15, 2019
AxelUser
pushed a commit
to AxelUser/Xamarin.Forms
that referenced
this pull request
Jun 15, 2019
samhouts
added
the
approved
|
Any feedback on whether we can get a quick revert of this PR @samhouts @davidortinau @paymicro ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes IsTabStop property in Layouts
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
Toggle Grid IsTabStopPR Checklist