Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Avoid acting on a disposed reference #4780

Merged
merged 1 commit into from Dec 18, 2018

Conversation

@samhouts
Copy link
Member

commented Dec 17, 2018

Description of Change

Fixes a UI test crash in 30935.

System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'Xamarin.Forms.Platform.Android.FormsEditText'.
12-17 13:17:21.290 I/MonoDroid(15560):   at Android.Views.View.RequestFocus () [0x0000a] in <0266c7f7d18f4d3580215846af2399e2>:0 
12-17 13:17:21.290 I/MonoDroid(15560):   at Xamarin.Forms.Platform.Android.ViewRenderer`2[TView,TNativeView].<OnFocusChangeRequested>b__30_0 () [0x00031] in <e7fd999147d542de8f25a4543d0d9869>:0 
12-17 13:17:21.290 I/MonoDroid(15560):   at Java.Lang.Thread+RunnableImplementor.Run () [0x00008] in <0266c7f7d18f4d3580215846af2399e2>:0 
12-17 13:17:21.290 I/MonoDroid(15560):   at Java.Lang.IRunnableInvoker.n_Run (System.IntPtr jnienv, System.IntPtr native__this) [0x00009] in <0266c7f7d18f4d3580215846af2399e2>:0 
12-17 13:17:21.290 I/MonoDroid(15560):   at (wrapper dynamic-method) System.Object.26(intptr,intptr)```

Issues Resolved

N/A

API Changes

None

Platforms Affected

  • Android

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

  1. Run B30935 test in Control Gallery
  2. No crash? Success!

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard
@samhouts

This comment has been minimized.

Copy link
Member Author

commented Dec 17, 2018

build --uitests

@samhouts samhouts added the e/1 🕐 label Dec 17, 2018

@mattleibow

This comment has been minimized.

Copy link
Contributor

commented Dec 18, 2018

LOL (not really a happy one though):

1 failed

Bugzilla41424
Date Picker Cancel Should Unfocus
Xamarin.Forms.Controls.Issues.Bugzilla41424.DatePickerCancelShouldUnfocus

@rmarinho rmarinho merged commit ef77b19 into 3.5.0 Dec 18, 2018

7 of 10 checks passed

VSTS: Android API19 Validation Fast Renderers UITests Finished
Details
VSTS: Android API19 Validation Legacy Renderers UITests Finished
Details
VSTS: Android API25 Validation Fast Renderers UITests Finished
Details
VSTS: Android API23 Validation Fast Renderers UITests Finished
Details
VSTS: Android API23 Validation Legacy Renderers UITests Finished
Details
VSTS: Android API25 Validation Legacy Renderers UITests Finished
Details
VSTS: iOS10 Validation UITests Finished
Details
VSTS: iOS11 Validation UITests Finished
Details
Xamarin Forms #PR-4780 - (2283596) succeeded
Details
license/cla All CLA requirements met.

v3.5.0 automation moved this from In Review to Done Dec 18, 2018

@samhouts samhouts added this to the 3.5.0 milestone Jan 10, 2019

@samhouts samhouts added the approved label Jul 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.