New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Setting ActivityIndicator.Color works now on W8.1 #479

Merged
merged 1 commit into from Nov 15, 2016

Conversation

Projects
None yet
4 participants
@jimmgarrido
Collaborator

jimmgarrido commented Oct 20, 2016

Description of Change

It turns out that setting the Foreground of an indeterminate ProgressBar on Windows 8.1 simply does not work: https://social.msdn.microsoft.com/Forums/windowsapps/en-US/957b333f-035f-448e-9f4a-213d1290ee51/indeterminate-progressbar-foreground-dosent-work?forum=winappswithcsharp

You have to override the control's ProgressBarIndeterminateForegroundThemeBrush brush resource instead. Fortunately this can be done programmatically so users can dynamically change the color.

Bugs Fixed

API Changes

None

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@samhouts samhouts changed the title from [Windows] Setting ActivityIdicator.Color works now on W8.1 to [Windows] Setting ActivityIndicator.Color works now on W8.1 Oct 22, 2016

@jassmith jassmith merged commit bdd14c5 into xamarin:master Nov 15, 2016

1 of 3 checks passed

iOS10-UITests Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Canceled (Exit co…
Details
iOS8-UITests Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified IOS8 : Tests failed: 1, p…
Details
iOS9-UITests Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Tests passed: 346,…
Details

@samhouts samhouts added this to the 2.3.4 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment