New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Win] Toolbar placement works with initial value #488

Merged
merged 2 commits into from Oct 26, 2016

Conversation

Projects
None yet
4 participants
@samhouts
Member

samhouts commented Oct 26, 2016

Description of Change

Can now use the Windows Platform Specific ToolbarPlacement in XAML and in constructor.

Bugs Fixed

  • n/a, reported internally

API Changes

None

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

hartez and others added some commits Oct 17, 2016

@hartez

hartez approved these changes Oct 26, 2016

@rmarinho rmarinho merged commit fc74c65 into master Oct 26, 2016

2 checks passed

OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle8 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle9 :: Windows Debug : Tests passed: 3461, ignored: 8
Details

@rmarinho rmarinho deleted the toolbar-placement-from-xaml branch Oct 26, 2016

rmarinho added a commit that referenced this pull request Oct 26, 2016

[Win] Toolbar placement works with initial value (#488)
* Defer UpdateToolbarPlacement until CommandBar is in the control hierarchy

* Cleanup

@samhouts samhouts modified the milestones: 2.3.4, 2.3.3 Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment