Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
[C, iOS, AND, UWP] TabbedPage SelectedTabColor and UnselectedTabColor #4899
Description of Change
I opened a previous PR (#3519) for this but that was an iOS-specific one, after the idea of #3478.
There was already an Android platform-specific for this, I have marked that as obsolete in favor of this.
The user is now able to specify a separate color for a selected and unselected tab. There shouldn't be any behavioral changes. Android users of the "old"
Added a case to the gallery root page
mattleibow left a comment •
I think we accidentally dropped support for the platform specific. What we can do is make the platform specific just set the real property. This way, we have all new and beautiful code, but the old platform specifics still work.
@mattleibow I see your point, I'm just not a big fan of multiple ways to do the same thing, that is why I chose to deprecate the one method. Still, for that time I might be able to change the implementation to set the new property. Else we'll have two properties and two ways of doing the same thing. I'm even less of a fan of that
This would also solve the (accidental) dropping the old way. Does that make sense?
Edit: Already made some changes, just awaiting the naming and deprecation then I guess!