New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WinRT] Fix ModalPushed/ModalPopped not firing #490

Merged
merged 1 commit into from Nov 15, 2016

Conversation

Projects
None yet
4 participants
@pauldipietro
Member

pauldipietro commented Oct 27, 2016

Description of Change

The ModalPushed and ModalPopped events were not firing on WinRT, which appears due to the NavigationProxy.Inner being assigned to newRoot and page values -- it appears that strictly leaving the value being assigned to Application.Current corrects this behavior (and Android/iOS both appear to set it similarly). The reproduction in the gallery checks the functionality while using other NavigationProxy functionality via InsertPageBefore to make certain it's still working after the changes, as well as inserting another page which unsubscribes from the added push/pop events when it appears.

Bugs Fixed

https://bugzilla.xamarin.com/show_bug.cgi?id=43663

API Changes

None

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@samhouts

Please rebase and fix the proj file. Thanks!

@samhouts samhouts self-assigned this Nov 10, 2016

@pauldipietro

This comment has been minimized.

Show comment
Hide comment
@pauldipietro

pauldipietro Nov 11, 2016

Member

Whoopsie, fixed.

Member

pauldipietro commented Nov 11, 2016

Whoopsie, fixed.

@jassmith jassmith merged commit 6bc6ee5 into master Nov 15, 2016

3 of 6 checks passed

iOS10-UITests Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle8 (EZ Test) :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Tests f…
Details
iOS8-UITests Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle8 (EZ Test) :: UI Tests :: OSX Test Cloud Package - Run iOS Unified IOS8 : Tests fa…
Details
iOS9-UITests Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle9 (EZ Test) :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Tests f…
Details
Android-UITests Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle9 (EZ Test) :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Tests passe…
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle9 (EZ Test) :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle9 (EZ Test) :: Windows Debug : Tests passed: 3461, ignored: 8
Details

@rmarinho rmarinho deleted the fix-bugzilla43663 branch Jun 22, 2017

@samhouts samhouts added this to the 2.3.4 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment