New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UWP] Explicitly set mobile StatusBar colors to white Background/black Foreground on Light theme #491

Merged
merged 3 commits into from Nov 15, 2016

Conversation

Projects
None yet
3 participants
@samhouts
Member

samhouts commented Oct 27, 2016

Description of Change

The mobile status bar appears as a blank white bar on version 14393 and a blank black bar on 10586 when the RequestedTheme is Light. This can be reproduced with a new UWP application independent of Xamarin.Forms.

Since the Light theme should have a white bar with black text, we are now explicitly setting the status bar to be those colors.

This is a VISUAL CHANGE on mobile devices targeting 10586, which would have a black status bar (with black text) in the Light theme.

Users preferring the black status bar can explicitly change the status bar colors in App.xaml.cs OnLaunched in the UWP project. See a1e802e for a complete example.

Bugs Fixed

API Changes

None

Behavioral Changes

This is a VISUAL CHANGE on mobile devices targeting 10586, which would have a black status bar (with black text) in the Light theme. See a1e802e for an example of reverting to the black status bar if desired.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

samhouts added some commits Oct 26, 2016

@jassmith jassmith merged commit 0cc2fd2 into master Nov 15, 2016

2 checks passed

OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle8 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle8 :: Windows Debug : Tests passed: 3461, ignored: 8
Details

@samhouts samhouts deleted the fix-bugzilla45835 branch Dec 5, 2016

@samhouts samhouts added this to the 2.3.4 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment