This repository was archived by the owner on May 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[AND] Fix opening of multiple Picker dialogs #4911
Merged
rmarinho
merged 1 commit into
xamarin:3.6.0
from
jfversluis:bug/4909-and-picker-multiple
Feb 12, 2019
Merged
[AND] Fix opening of multiple Picker dialogs #4911
rmarinho
merged 1 commit into
xamarin:3.6.0
from
jfversluis:bug/4909-and-picker-multiple
Feb 12, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saamerm
reviewed
Jan 8, 2019
paymicro
approved these changes
Jan 17, 2019
Contributor
|
build --uitests |
Member
Author
|
Anything I can fix for this? |
minaairsupport
approved these changes
Feb 1, 2019
minaairsupport
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think checking for null enough
Contributor
|
@jfversluis can you rebase this to |
Member
Author
|
@paymicro done, but brings in a couple of commits which are not mine. Also need a retarget? |
kingces95
approved these changes
Feb 11, 2019
Member
|
Failing tests not related |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
As described in #4909, when the end-user is fast enough, it is possible to open multiple Picker dialogs. This PR fixes that.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
PR Checklist