Skip to content
This repository was archived by the owner on May 1, 2024. It is now read-only.

Conversation

@jfversluis
Copy link
Member

Description of Change

As described in #4909, when the end-user is fast enough, it is possible to open multiple Picker dialogs. This PR fixes that.

Issues Resolved

API Changes

None

Platforms Affected

  • Android

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard

@samhouts
Copy link
Contributor

build --uitests

@jfversluis
Copy link
Member Author

Anything I can fix for this?

Copy link

@minaairsupport minaairsupport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think checking for null enough

@paymicro
Copy link
Contributor

paymicro commented Feb 8, 2019

@jfversluis can you rebase this to 3.6.0? Thanks

@jfversluis
Copy link
Member Author

@paymicro done, but brings in a couple of commits which are not mine. Also need a retarget?

@paymicro paymicro changed the base branch from master to 3.6.0 February 8, 2019 10:54
@rmarinho
Copy link
Member

Failing tests not related

@rmarinho rmarinho merged commit c60b58d into xamarin:3.6.0 Feb 12, 2019
@jfversluis jfversluis deleted the bug/4909-and-picker-multiple branch February 12, 2019 13:26
@samhouts samhouts modified the milestones: 4.0.0, 3.6.0 Feb 20, 2019
@samhouts samhouts added the approved Has two approvals, no pending reviews, and no changes requested label Jul 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Has two approvals, no pending reviews, and no changes requested e/1 🕐 1 p/Android t/bug 🐛

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants