New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] set ClipBounds to use ViewCompat.SetClipBounds #4954

Merged
merged 1 commit into from Jan 15, 2019

Conversation

@PureWeen
Copy link
Contributor

PureWeen commented Jan 10, 2019

Description of Change

  • Due to a regression modify ImageElementManager to use ViewCompat.SetClipBounds so as to not cause crashing

I realize that there is a ClipBounds here in CollectionView code

But CollectionView is new code that only supports >= 19 so it wouldn't set a good precedence to fix CV to be compatible pre api 19

Issues Resolved

Platforms Affected

  • Android

Testing Procedure

Run ImageButton Gallery on pre api 18 device

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard
@hartez

hartez approved these changes Jan 11, 2019

@samhouts samhouts added the e/1 🕐 label Jan 11, 2019

@PureWeen

This comment has been minimized.

Copy link
Contributor

PureWeen commented Jan 14, 2019

build --uitests

@rmarinho rmarinho merged commit 588023e into 3.4.0 Jan 15, 2019

10 checks passed

VSTS: Android API19 Validation Fast Renderers UITests Finished
Details
VSTS: Android API19 Validation Legacy Renderers UITests Finished
Details
VSTS: Android API23 Validation Fast Renderers UITests Finished
Details
VSTS: Android API23 Validation Legacy Renderers UITests Finished
Details
VSTS: Android API25 Validation Fast Renderers UITests Finished
Details
VSTS: Android API25 Validation Legacy Renderers UITests Finished
Details
VSTS: iOS10 Validation UITests Finished
Details
VSTS: iOS11 Validation UITests Finished
Details
Xamarin Forms #PR-4954 - (2328239) succeeded
Details
license/cla All CLA requirements met.

vCurrent (Target 3.4.0) automation moved this from In Review to Done Jan 15, 2019

Sprint 147 automation moved this from Ready for Review (PRs) to Done Jan 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment