New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frame CornerRadius #496

Merged
merged 2 commits into from Nov 15, 2016

Conversation

Projects
None yet
7 participants
@StephaneDelcroix
Member

StephaneDelcroix commented Nov 1, 2016

this replace #433 from @andreinitescu

Please do not squash merge to preserve original author attribution

Description of Change

Added CornerRadius property to the Frame control to customize Frame's corner radius value.

Bugs Fixed

N/A

API Changes

Added:

  • public float Frame.CornerRadius { get; set; } //Bindable Property
  • public static readonly BindableProperty Frame.CornerRadiusProperty;

Behavioral Changes

The property default value ensures the appearance of the Frame control in current apps remains unchanged.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@dnfclas dnfclas added the cla-required label Nov 1, 2016

@StephaneDelcroix StephaneDelcroix referenced this pull request Nov 1, 2016

Closed

Added CornerRadius property To Frame control #433

1 of 4 tasks complete

@StephaneDelcroix StephaneDelcroix self-assigned this Nov 1, 2016

@StephaneDelcroix StephaneDelcroix changed the title from Frame cornerradius to Frame CornerRadius Nov 8, 2016

@samhouts samhouts self-assigned this Nov 10, 2016

@jassmith jassmith merged commit 0d883f6 into master Nov 15, 2016

4 of 6 checks passed

iOS10-UITests Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle8 (EZ Test) :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Tests f…
Details
iOS9-UITests Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle8 (EZ Test) :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Exit cod…
Details
Android-UITests Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle9 (EZ Test) :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Tests passe…
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle9 (EZ Test) :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle9 (EZ Test) :: Windows Debug : Tests passed: 3461, ignored: 8
Details
iOS8-UITests Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle8 (EZ Test) :: UI Tests :: OSX Test Cloud Package - Run iOS Unified IOS8 : Tests pa…
Details
@japhiaolson

This comment has been minimized.

Show comment
Hide comment
@japhiaolson

japhiaolson Jan 18, 2017

#496 Works great in Android however iOS is missing a line. In the OnElementPropertyChanged you have to add the CornerRadiusProperty bit to the if statement.

|| e.PropertyName == Xamarin.Forms.Frame.CornerRadiusProperty.PropertyName

japhiaolson commented Jan 18, 2017

#496 Works great in Android however iOS is missing a line. In the OnElementPropertyChanged you have to add the CornerRadiusProperty bit to the if statement.

|| e.PropertyName == Xamarin.Forms.Frame.CornerRadiusProperty.PropertyName

@StephaneDelcroix StephaneDelcroix referenced this pull request Jan 18, 2017

Merged

[iOS] redraw Frame on CornerRadius changed #697

3 of 4 tasks complete
@rmarinho

This comment has been minimized.

Show comment
Hide comment
@rmarinho
Member

rmarinho commented Jan 21, 2017

@japhiaolson fixed on #697

@StephaneDelcroix StephaneDelcroix deleted the frame-cornerradius branch Jan 31, 2017

@samhouts samhouts added this to the 2.3.4 milestone Jul 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment