Skip to content
This repository was archived by the owner on May 1, 2024. It is now read-only.

[iOS] Fixed updating Label TextDecorations when no Text is set #5013

Merged
StephaneDelcroix merged 1 commit into from
Feb 19, 2019
Merged

[iOS] Fixed updating Label TextDecorations when no Text is set #5013

StephaneDelcroix merged 1 commit into from
Feb 19, 2019

Conversation

@andreinitescu
Copy link
Contributor

@andreinitescu andreinitescu commented Jan 18, 2019 •
edited
Loading

Description of Change

Issues Resolved

API Changes

None

Platforms Affected

  • iOS

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard

paymicro
paymicro suggested changes Jan 24, 2019
View reviewed changes
paymicro
paymicro reviewed Jan 24, 2019
View reviewed changes
@andreinitescu
Copy link
Contributor Author

andreinitescu commented Jan 27, 2019

All should be good now

@andreinitescu andreinitescu mentioned this pull request Feb 6, 2019
Closed
@rmarinho
Copy link
Member

rmarinho commented Feb 13, 2019

sorry @AndreiMisiukevich needs rebase also to fix some provisioning issue.

@AndreiMisiukevich
Copy link
Contributor

AndreiMisiukevich commented Feb 13, 2019

sorry @AndreiMisiukevich needs rebase also to fix some provisioning issue.

It must be you meant @andreinitescu

@andreinitescu
Copy link
Contributor Author

andreinitescu commented Feb 13, 2019

The other Andrei is done.

@andreinitescu andreinitescu mentioned this pull request Feb 14, 2019
Closed
@samhouts samhouts added the retarget-branch-required PR or associated issues target a milestone. Please target this PR to the matching branch. label Feb 15, 2019
@StephaneDelcroix StephaneDelcroix changed the base branch from master to 3.6.0 February 18, 2019 08:20
@StephaneDelcroix StephaneDelcroix changed the base branch from 3.6.0 to master February 18, 2019 08:21
@StephaneDelcroix
Copy link
Member

StephaneDelcroix commented Feb 18, 2019

@andreinitescu could you please rebase this on top of the 3.6.0 branch, and then change the target of the PR ? thanks

@andreinitescu andreinitescu changed the base branch from master to 3.6.0 February 18, 2019 10:14
@andreinitescu
Copy link
Contributor Author

andreinitescu commented Feb 18, 2019

@StephaneDelcroix Done!

@StephaneDelcroix StephaneDelcroix removed the retarget-branch-required PR or associated issues target a milestone. Please target this PR to the matching branch. label Feb 19, 2019
@StephaneDelcroix StephaneDelcroix merged commit 0ba2e10 into xamarin:3.6.0 Feb 19, 2019
@AndreiMisiukevich AndreiMisiukevich mentioned this pull request Feb 19, 2019
Closed
@samhouts samhouts added the retarget-branch-required PR or associated issues target a milestone. Please target this PR to the matching branch. label Feb 19, 2019
@samhouts samhouts added this to the 3.6.0 milestone Mar 5, 2019
@alanag13 alanag13 mentioned this pull request Mar 18, 2019
Closed
@samhouts samhouts added the approved Has two approvals, no pending reviews, and no changes requested label Jul 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@rmarinho rmarinho rmarinho requested changes

@kingces95 kingces95 kingces95 approved these changes

@paymicro paymicro paymicro approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kingces95 kingces95

@paymicro paymicro

Labels

approved Has two approvals, no pending reviews, and no changes requested e/1 🕐 1 i/regression p/iOS 🍎 retarget-branch-required PR or associated issues target a milestone. Please target this PR to the matching branch. t/bug 🐛

Projects

None yet

Milestone

3.6.0

Development

Successfully merging this pull request may close these issues.

7 participants

@andreinitescu @rmarinho @AndreiMisiukevich @StephaneDelcroix @kingces95 @paymicro @samhouts