New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Material] [Android, iOS] Materializing the stepper #5027
Conversation
When testing the tabstops fix in #5000 (which I have included here because I modified the renderer code), I noticed that the Material stepper doesn't seem to be working with tabs. I am not yet sure what the cause may be, but I do see a lot of extra code in the base renderers that we may need to re-implement. |
I reverted the changes to use a "Fast" renderer as it doesn't seem to work with multiple children views. I probably need to investigate this further, but for now steppers aren't the most important control. |
To test the tab stops on Android, we also need #4612. |
Thanks for the feedback, will get on that. In the meantime, I added the iOS one. Not sure if creating a new "control" is cool for iOS - or where I should put it. This is not exactly what I wanted to do, since there is no need for the control - I can just do the layout in the renderer. But, I can't seem to find the concept of a no-native-view renderer. I am also thinking that this might also be good for Android. |
} | ||
} | ||
|
||
public class MaterialStepper : UIView |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure where we want to put this - this is very this-renderer specific and has no use elsewhere. Basically - just for layout.
This comment is still up for discussion: |
e9cc09f
to
a4ae17d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just have a few questions.
- reuse code between default and material - added material stepper
…5011 - switched the button style to the outlined buttons
… to get tabstops working
Co-Authored-By: mattleibow <mattleibow@live.com>
- we still need to decide on the logic behind the coloring of outline buttons
df944b4
to
797eca7
Compare
Description of Change
Adding a renderer for the material stepper:
Issues Resolved
API Changes
MaterialStepperRenderer
StepperRendererManager
to manage all stepper logicPlatforms Affected
Behavioral/Visual Changes
Before/After Screenshots
Material (with full-width characters / new characters)
Default (with full-width characters)
Material (with plus and hyphen / old characters)
Testing Procedure
Should just be a visual style change when using Material. Functionality should be exactly the same.
PR Checklist