New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Disposing MasterDetailPage when Detail has a FragmentContainer should not crash #505

Merged
merged 1 commit into from Nov 15, 2016

Conversation

Projects
None yet
5 participants
@adrianknight89
Contributor

adrianknight89 commented Nov 4, 2016

Description of Change

If you create a MasterDetailPage where its detail is set to a NavigationPage or any other page wrapped in a fragment container and when you hit the back button to go to home screen, destroying current activity can run into a race condition such that the fragment is attempted to be destroyed after the activity is gone.

We should invoke base activity destroy only after our resources are destroyed.

Note that the test case does not work with the gallery app since the back button dismisses the MDP UI instead of sending you home.

Ref #444

Bugs Fixed

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@samhouts samhouts self-assigned this Nov 10, 2016

@jassmith

This comment has been minimized.

Show comment
Hide comment
@jassmith

jassmith Nov 15, 2016

Member

Please rebase, otherwise 👍

Member

jassmith commented Nov 15, 2016

Please rebase, otherwise 👍

@adrianknight89

This comment has been minimized.

Show comment
Hide comment
@adrianknight89
Contributor

adrianknight89 commented Nov 15, 2016

@jassmith Done.

@hartez hartez merged commit ffab780 into xamarin:master Nov 15, 2016

1 check passed

Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 9 :: Windows Debug : Tests passed: 3563, ignored: 10
Details

jassmith added a commit that referenced this pull request Jan 17, 2017

@samhouts samhouts added this to the 2.3.4 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment