Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Set Page background color #5066

Merged
merged 6 commits into from Feb 18, 2019

Conversation

@andreinitescu
Copy link
Contributor

commented Jan 26, 2019

Description of Change

On Android, setting Page BackgroundColor doesn't work.
Also, iOS and UWP implement a priority of BackgroundImage over BackgroundColor. If both are set BackkgroundImage is used.

Issues Resolved

Video with the fix (click to view full screen):

pagebkgnd

API Changes

None

Platforms Affected

  • Android

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard

@andreinitescu andreinitescu force-pushed the andreinitescu:fix-5057 branch from 7e1ee6e to 35cc30a Jan 26, 2019

@andreinitescu andreinitescu force-pushed the andreinitescu:fix-5057 branch from 35cc30a to 68bb050 Jan 27, 2019

@samhouts samhouts added this to In Review in v3.6.0 Jan 29, 2019

@samhouts samhouts added this to Ready for Review (PRs) in Sprint 148 Jan 29, 2019

@samhouts

This comment has been minimized.

Copy link
Member

commented Jan 29, 2019

@andreinitescu Can you rebase to 3.5.0 branch? Thanks!

@andreinitescu

This comment has been minimized.

Copy link
Contributor Author

commented Jan 29, 2019

@samhouts Done!

@andreinitescu

This comment has been minimized.

Copy link
Contributor Author

commented Jan 29, 2019

oh wait, you said 3.5.0

@andreinitescu andreinitescu force-pushed the andreinitescu:fix-5057 branch from b78b53e to ffae904 Jan 29, 2019

@andreinitescu andreinitescu requested a review from StephaneDelcroix as a code owner Jan 29, 2019

@andreinitescu andreinitescu force-pushed the andreinitescu:fix-5057 branch from ffae904 to 80661f7 Jan 29, 2019

@andreinitescu andreinitescu changed the base branch from master to 3.5.0 Jan 29, 2019

@andreinitescu

This comment has been minimized.

Copy link
Contributor Author

commented Jan 29, 2019

@samhouts Done!

@samhouts samhouts requested review from kingces95 and paymicro Jan 29, 2019

@samhouts samhouts removed this from In Review in v3.6.0 Jan 29, 2019

@samhouts samhouts added this to In Review in v3.5.0 Jan 29, 2019

@samhouts

This comment has been minimized.

Copy link
Member

commented Jan 29, 2019

build --uitests

@mattleibow

This comment has been minimized.

Copy link
Contributor

commented Feb 1, 2019

Fixed the merge conflict... hope I didn't break it 😬

@mattleibow

This comment has been minimized.

Copy link
Contributor

commented Feb 1, 2019

build

Sprint 148 automation moved this from In progress to Ready for Review (PRs) Feb 1, 2019

@samhouts samhouts moved this from Ready for Review (PRs) to In progress in Sprint 148 Feb 1, 2019

@samhouts samhouts added this to In Progress in v4.0.0 Feb 2, 2019

@samhouts samhouts removed this from In Progress in v3.6.0 Feb 2, 2019

@samhouts samhouts modified the milestone: 3.5.0 Feb 5, 2019

@samhouts samhouts removed this from In Progress in v4.0.0 Feb 6, 2019

@samhouts samhouts added this to In Progress in v3.5.0 Feb 6, 2019

@samhouts samhouts removed this from the 3.5.0 milestone Feb 12, 2019

@samhouts samhouts added this to In Progress in v4.0.0 Feb 12, 2019

@samhouts samhouts removed this from In Progress in v3.5.0 Feb 12, 2019

@rmarinho rmarinho merged commit 2277ce8 into xamarin:master Feb 18, 2019

7 of 8 checks passed

Xamarin Forms Build scheduled in AzureDevOps
Details
Xamarin Forms Build #PR-5066 - (2404181) succeeded
Details
Xamarin Forms (Build Windows Phase Debug,any cpu) Build Windows Phase Debug,any cpu succeeded
Details
Xamarin Forms (Nuget Phase) Nuget Phase succeeded
Details
Xamarin Forms (OSX Phase) OSX Phase succeeded
Details
Xamarin Forms (Prepare Build Phase) Prepare Build Phase succeeded
Details
Xamarin Forms (Test Phase debug) Test Phase debug succeeded
Details
license/cla All CLA requirements met.
Details

Sprint 148 automation moved this from In progress to Done Feb 18, 2019

v4.0.0 automation moved this from In Progress to Done Feb 18, 2019

@samhouts samhouts added this to the 3.5.0 milestone Feb 19, 2019

@samhouts samhouts removed this from Done in v4.0.0 Feb 20, 2019

@samhouts samhouts added this to Done in v3.5.0 Feb 20, 2019

AxelUser added a commit to AxelUser/Xamarin.Forms that referenced this pull request Jun 15, 2019
[Android] Set Page background color (xamarin#5066) * Fixes xamarin#5057
… * closes xamarin#4916 * Fixes xamarin#5073

* [Android] Fix setting Page background color

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue5057.xaml.cs

Co-Authored-By: andreinitescu <nitescua@yahoo.com>

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue5057.xaml.cs

Co-Authored-By: andreinitescu <nitescua@yahoo.com>

* Refactoring and added test info

* Update Xamarin.Forms.Platform.Android/Renderers/PageRenderer.cs

Co-Authored-By: andreinitescu <nitescua@yahoo.com>

@samhouts samhouts added the approved label Jul 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.