Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] fix accessibility of Picker #5125

Merged
merged 9 commits into from Jun 19, 2019
Merged

[Android] fix accessibility of Picker #5125

merged 9 commits into from Jun 19, 2019

Conversation

paymicro
Copy link
Contributor

@paymicro paymicro commented Feb 4, 2019 •
edited by samhouts

Description of Change

Changed accessibility of Picker. Now it reads like a button. If something is selected in it, this item is also read. This is part of PR #3955

Issues Resolved

API Changes

None

Platforms Affected

  • Android

Behavioral/Visual Changes

Picker supports accessibility parameters without changing hint/placeholder of control.

Before/After Screenshots

Before
image

After
image

Testing Procedure

  • run UItest 3454
  • check accessibility of Pickers

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard

@samhouts samhouts added this to In Review in v4.0.0 Feb 4, 2019
@PureWeen PureWeen self-assigned this Feb 6, 2019
@PureWeen PureWeen removed the inactive Issue is older than 6 months and needs to be retested label Feb 20, 2019
@samhouts samhouts added this to In Review in v4.1.0 Mar 2, 2019
@samhouts samhouts removed this from In Review in v4.0.0 Mar 2, 2019
@PureWeen
Copy link
Contributor

PureWeen commented Mar 8, 2019

@paymicro

  • rebase to fix conflicts I'm curious to tests these with material :-)
  • I have one question about what it reads back. After you select something from the picker it reads the text "Control Gallery" in the middle of reading back about the button. That doesn't seem quite right. Otherwise it looks like it's working great!!

@samhouts samhouts self-requested a review March 13, 2019 00:50
@samhouts samhouts self-assigned this Mar 13, 2019
@samhouts samhouts changed the base branch from master to 4.0.0 March 27, 2019 23:24
@samhouts samhouts removed this from In Review in v4.1.0 Mar 28, 2019
@samhouts samhouts added this to In Review in v4.0.0 Mar 28, 2019
@PureWeen PureWeen moved this from In Review to In Progress in v4.0.0 Apr 2, 2019
samhouts
samhouts requested changes Apr 2, 2019
View reviewed changes
Copy link
Member

@samhouts samhouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See @PureWeen's feedback. Thanks!

@paymicro
Copy link
Contributor Author

paymicro commented Apr 4, 2019 •
edited

@PureWeen done! Please re-review.

  • With material is working correctly.
  • Reading "Control Gallery" after closing dialog not fixed. Apparently, we need another fix.

@paymicro paymicro requested a review from samhouts April 4, 2019 14:55
PureWeen
PureWeen requested changes Apr 6, 2019
View reviewed changes
Copy link
Contributor

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading "Control Gallery" after closing dialog not fixed. Apparently, we need another fix.

So are you thinking this is something else outside the pickers causing this? If so can you create another issue please?

Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue3454.cs Outdated Show resolved Hide resolved
Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue3454.cs Outdated Show resolved Hide resolved
Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue3454.cs Outdated Show resolved Hide resolved
@samhouts samhouts requested a review from PureWeen April 29, 2019 18:14
samhouts
samhouts approved these changes Apr 29, 2019
View reviewed changes
Copy link
Member

@samhouts samhouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Thanks!

Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue3454.cs Outdated Show resolved Hide resolved
samhouts
samhouts previously requested changes Apr 29, 2019
View reviewed changes
Copy link
Member

@samhouts samhouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 


Xamarin.Forms.Controls.Issues\Xamarin.Forms.Controls.Issues.Shared\Issue3454.cs(19,9): Error CS8321: The local function 'AddPicker' is declared but never used
--
  | Xamarin.Forms.Controls.Issues\Xamarin.Forms.Controls.Issues.Shared\Issue3454.cs(19,9): Error CS8321: The local function 'AddPicker' is declared but never used
  | Xamarin.Forms.Controls.Issues\Xamarin.Forms.Controls.Issues.Shared\Issue3454.cs(19,9): Error CS8321: The local function 'AddPicker' is declared but never used
  | Xamarin.Forms.Controls.Issues\Xamarin.Forms.Controls.Issues.Shared\Issue3454.cs(28,8): Error CS0219: The variable 'index' is assigned but its value is never used
  | Xamarin.Forms.Controls.Issues\Xamarin.Forms.Controls.Issues.Shared\Issue3454.cs(19,9): Error CS8321: The local function 'AddPicker' is declared but never used
  | Process 'msbuild.exe' exited with code '1'.

paymicro and others added 2 commits May 6, 2019 13:21
@paymicro
fix build uitest
f36412f
@samhouts @paymicro
Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Sh…
68a0f08 
…ared/Issue3454.cs

Co-Authored-By: paymicro <v-payako@microsoft.com>
samhouts and others added 2 commits May 7, 2019 11:06
@samhouts samhouts dismissed their stale review May 10, 2019 00:32

fixed warnings

@samhouts samhouts added this to the 4.0.0 milestone May 29, 2019
@samhouts samhouts added inactive Issue is older than 6 months and needs to be retested and removed e/5 🕔 5 labels Jun 3, 2019
@samhouts samhouts changed the base branch from 4.0.0 to 4.1.0 June 19, 2019 23:20
@samhouts samhouts modified the milestones: 4.0.0, 4.1.0 Jun 19, 2019
@samhouts samhouts merged commit ccfd617 into xamarin:4.1.0 Jun 19, 2019
v4.0.0 automation moved this from In Progress to Done Jun 19, 2019
@samhouts samhouts removed this from Done in v4.0.0 Jun 20, 2019
@samhouts samhouts added this to Done in v4.1.0 Jun 20, 2019
@samhouts samhouts added this to the 4.1.0 milestone Jun 21, 2019
@paymicro paymicro deleted the fix-gh3454-picker-accessibility-android branch July 9, 2019 15:59
@samhouts samhouts mentioned this pull request Sep 6, 2019
Closed
@samhouts samhouts added this to Done in Accessibility Feb 20, 2020
@samhouts samhouts removed this from Done in Accessibility May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samhouts samhouts samhouts approved these changes

@PureWeen PureWeen Awaiting requested review from PureWeen

Assignees

@PureWeen PureWeen

@samhouts samhouts

Labels
a/a11y 🔍 inactive Issue is older than 6 months and needs to be retested m/high impact ⬛ p/Android p/iOS 🍎 t/bug 🐛
Projects
No open projects
v4.1.0
  
Done
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paymicro @PureWeen @samhouts