New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XamlC] use correct filePath for XamlC error reporting #513

Merged
merged 3 commits into from Nov 16, 2016

Conversation

Projects
None yet
4 participants
@StephaneDelcroix
Member

StephaneDelcroix commented Nov 8, 2016

Description of Change

[XamlC] use correct filePath for XamlC error reporting.

Instead of using the resourceName, report build errors with the file name so you can click on the error on the IDE and get directly to the right xaml file and the faulty position.

Bugs Fixed

  • I do not fix bugs, I create them

API Changes

List all API changes here (or just put None), example:

Added:

  • public class XamlFilePathAttribute

Behavioral Changes

Ponies, rainbows, UNICORNS

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@@ -1,5 +1,6 @@
using System;
using System.Reflection;
using System.Runtime.CompilerServices;

This comment has been minimized.

@StephaneDelcroix

StephaneDelcroix Nov 9, 2016

Member

not required, I KNOW

@StephaneDelcroix

StephaneDelcroix Nov 9, 2016

Member

not required, I KNOW

public sealed class XamlFilePathAttribute : Attribute
{
public XamlFilePathAttribute([CallerFilePath] string filePath = "")
{

This comment has been minimized.

@StephaneDelcroix

StephaneDelcroix Nov 9, 2016

Member

the attribute is never used, because we do not care about the instance of the attribute, but its constructor call only

@StephaneDelcroix

StephaneDelcroix Nov 9, 2016

Member

the attribute is never used, because we do not care about the instance of the attribute, but its constructor call only

@jassmith jassmith merged commit d97dfe9 into master Nov 16, 2016

1 check passed

Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 9 :: Windows Debug : Tests passed: 3563, ignored: 10
Details

@StephaneDelcroix StephaneDelcroix deleted the xamlc-filepaths branch Jan 31, 2017

@samhouts samhouts added this to the 2.3.4 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment