New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS/Android] Handle item selection highlight when ListView cell is tapped erratically #520

Merged
merged 3 commits into from Feb 6, 2017

Conversation

Projects
None yet
4 participants
@adrianknight89
Contributor

adrianknight89 commented Nov 11, 2016

Description of Change

On iOS and Android, if you push a page on ListView item selected event and when you then go back to the previous page, renderers can't decide if the next selected item change comes from a native tap or some other action. This happens when selected item change is called multiple times with frequent taps and flags fall out of sync. See changes and sample code for a better understanding.

Bugs Fixed

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@rmarinho

This comment has been minimized.

Show comment
Hide comment
@rmarinho

rmarinho Jan 12, 2017

Member

Needs rebase @adrianknight89

Member

rmarinho commented Jan 12, 2017

Needs rebase @adrianknight89

@adrianknight89

This comment has been minimized.

Show comment
Hide comment
@adrianknight89

adrianknight89 Jan 12, 2017

Contributor

Done.

Contributor

adrianknight89 commented Jan 12, 2017

Done.

@rmarinho rmarinho merged commit 28237b7 into xamarin:master Feb 6, 2017

6 checks passed

Android-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Tests passed: 351, i…
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: Windows Debug : Tests passed: 3697, ignored: 10
Details
iOS10-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Tests passed: 34…
Details
iOS8-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified IOS8 : Tests passed: 345…
Details
iOS9-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Running
Details

@samhouts samhouts referenced this pull request Apr 25, 2017

Merged

[iOS] Prevent NRE in ListView OnItemSelected #883

4 of 4 tasks complete

rmarinho added a commit that referenced this pull request Jul 28, 2017

@rmarinho rmarinho referenced this pull request Jul 28, 2017

Merged

[iOS] Fix regression introduced on #520 #1072

0 of 4 tasks complete

rmarinho added a commit that referenced this pull request Aug 1, 2017

@samhouts samhouts added D-15.4 and removed cla-already-signed labels Oct 10, 2017

@samhouts samhouts added this to the 2.3.5 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment