Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map with ItemTemplateSelector #5226

Merged
merged 2 commits into from Apr 1, 2019

Conversation

@andreinitescu
Copy link
Contributor

andreinitescu commented Feb 13, 2019

Description of Change

Added ItemTemplateSelector property to Map

See #4269 (comment)

API Changes

Added:

  • DataTemplateSelector Map.ItemTemplateSelector { get; set; } //Bindable Property

Platforms Affected

  • Core/XAML (all platforms)

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard
@samhouts samhouts added this to In Review in v4.0.0 Feb 13, 2019
@samhouts samhouts added this to In Review in v4.1.0 Mar 2, 2019
@samhouts samhouts removed this from In Review in v4.0.0 Mar 2, 2019
@samhouts samhouts requested review from paymicro and samhouts Mar 13, 2019
Copy link
Member

samhouts left a comment

Test failing: Xamarin.Forms.Core.UnitTests.MapTests.ItemTemplateTakesPrecendenceOverItemTemplateSelector

@samhouts samhouts moved this from In Review to In Progress in v4.1.0 Mar 19, 2019
@andreinitescu andreinitescu force-pushed the andreinitescu:Map-ItemTemplateSelector branch from b9dd5e4 to 549a648 Mar 26, 2019
@andreinitescu

This comment has been minimized.

Copy link
Contributor Author

andreinitescu commented Mar 26, 2019

@samhouts Done. Test fixed.

@samhouts samhouts added the API-change label Apr 1, 2019
@samhouts samhouts merged commit 740654f into xamarin:master Apr 1, 2019
7 checks passed
7 checks passed
Xamarin Forms Build #PR-5226 - (2529610) succeeded
Details
Xamarin Forms (Build Windows Phase Debug,any cpu) Build Windows Phase Debug,any cpu succeeded
Details
Xamarin Forms (Nuget Phase) Nuget Phase succeeded
Details
Xamarin Forms (OSX Phase) OSX Phase succeeded
Details
Xamarin Forms (Prepare Build Phase) Prepare Build Phase succeeded
Details
Xamarin Forms (Test Phase debug) Test Phase debug succeeded
Details
license/cla All CLA requirements met.
Details
v4.1.0 automation moved this from In Progress to Done Apr 1, 2019
codemillmatt added a commit to codemillmatt/Xamarin.Forms that referenced this pull request Apr 19, 2019
* Map with ItemTemplateSelector

* Fixed Map test
@samhouts samhouts added this to Done in v4.2.0 May 29, 2019
@samhouts samhouts removed this from Done in v4.1.0 May 29, 2019
@samhouts samhouts added this to the 4.1.0 milestone Jun 4, 2019
@samhouts samhouts removed this from Done in v4.2.0 Jun 4, 2019
@samhouts samhouts added this to Done in v4.1.0 Jun 4, 2019
AxelUser added a commit to AxelUser/Xamarin.Forms that referenced this pull request Jun 15, 2019
* Map with ItemTemplateSelector

* Fixed Map test
@samhouts samhouts added the approved label Jul 2, 2019
@andreas-nesheim andreas-nesheim mentioned this pull request Sep 23, 2019
2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v4.1.0
  
Done
3 participants
You can’t perform that action at this time.