Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[iOS] Fix NavigationPage memory leak when back button title is set #523
Description of Change
I tried setting the
P.S. I can't quite understand what
At this time i reverted that code so we can ship stable that doesn't throw that exception, also it was making impossible to dispose some renderers. But i will get back to try to fix that bug again 39908.
Just to explain you my fix there, the problem is when a page is popped via click on the back button very fast the way we update the stack on the XF side gets mixed up. So i used other aproach: DidMoveToParentViewController is called with parent null when a ViewController is being removed, and in there we check if we should update the Forms side ( normally always that pop is done via the UI and not using XF api) .. But the current code was missing stuff. I need to get back to it.
Please rebase and check if this leak that you are trying to fix still happens.
I can conclude the same thing, when I assign my own back-button. It's completely ignoring the event-handler and calling page pop on it's own.