Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[iOS/Critical] Fix ListView memory leaks #524
Description of Change
See comments for details.
P.S. It was mentioned that the same issue occurs on Android, but I wasn't able to reproduce it on AppCompat (at least not with the sample code in this PR).
EDIT: Also included the fix for another bug concerning context actions not being properly disposed.
At first glance this looks pretty good; I'll have to spend some time on Monday looking more closely at the subview disposal stuff you mentioned.
Could you add some instructions to the test so when the case is being manually verified the tester knows what to look for?
Code changes look good, just need to make some adjustments to the tests.
@hartez I addressed the issues except for the UI tests. When I try to compile
@hartez I have added a UI test for
Also came across another bug where, if you push and pop the page rapidly, eventually a page will start leaking. This could be a problem with
P.S. I haven't verified this.
P.P.S. I think that test also has the same issue. I added a static label to
@adrianknight89 I think making the Label static is causing your problems. Change it to
And instead of accessing it from the landing page like this:
Just let the UI test framework look for the correct value:
This was referenced
Dec 9, 2016
referenced this pull request
Dec 10, 2016
@hartez There seems to be an issue with the way
This doesn't seem to dispose renderers. So, at the moment,
So we put your changes on top of our fork by itself. We were specifically trying to fix a memory leak with
I guess because we have lots of headers, it could cause the NRE. It is also possible we have a custom renderer as a header.