Platform specifics naming adjustments #526

Merged
merged 1 commit into from Nov 18, 2016

Conversation

Projects
None yet
4 participants
@pauldipietro
Member

pauldipietro commented Nov 14, 2016

Description of Change

Renaming of some platform specifics stuff per @davidbritch's request -- namely AdjustsFontSizeToFitWidth to IsAdjustsFontSizeToFitWidthEnabled and SetOffscreenPageLimitProperty to SetOffscreenPageLimit.

Edit: Updated to only use the latter.

Bugs Fixed

N/A

API Changes

See description changes.

Behavioral Changes

N/A

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@StephaneDelcroix

This comment has been minimized.

Show comment
Hide comment
@StephaneDelcroix

StephaneDelcroix Nov 15, 2016

Member

when was this implemented ? is this a breaking change ?

Member

StephaneDelcroix commented Nov 15, 2016

when was this implemented ? is this a breaking change ?

@jassmith

This comment has been minimized.

Show comment
Hide comment
@jassmith

jassmith Nov 16, 2016

Member

No these names are still unreleased

Member

jassmith commented Nov 16, 2016

No these names are still unreleased

@jassmith

This comment has been minimized.

Show comment
Hide comment
@jassmith

jassmith Nov 16, 2016

Member

First change no, second change yes.

Member

jassmith commented Nov 16, 2016

First change no, second change yes.

@pauldipietro

This comment has been minimized.

Show comment
Hide comment
@pauldipietro

pauldipietro Nov 17, 2016

Member

Got around to doing this.

Member

pauldipietro commented Nov 17, 2016

Got around to doing this.

@StephaneDelcroix StephaneDelcroix merged commit b2e2a8f into master Nov 18, 2016

@StephaneDelcroix StephaneDelcroix deleted the ps-renaming branch Nov 18, 2016

@samhouts samhouts added this to the 2.3.4 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment