Make CommitAllowingStateLoss the default for FragmentTransactions #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
I'm okay with this in favor of the other PR. |
|
Possibly fixes this too: https://bugzilla.xamarin.com/show_bug.cgi?id=47367 |
|
Another possibly related issue: https://bugzilla.xamarin.com/show_bug.cgi?id=42815 |
|
Hey @adrianknight89, any idea when this fix gonna hit the road? |
|
I'm not 100% sure, but I'd wait for 2.3.4-pre2. Hopefully later this month or early next month. |
|
Can you confirm it is NOT released in 2.3.4-pre1 then? |
|
@stefandevo it was shipped in 2.3.4-pre1 , we were going to call it 2.3.4-pre2 but it was shipped last week as pre1 |
|
What stable release version will this be in then? Thanks! I thought it would be in 2.3.3.180 |
|
Yes please, our users are heavily affected by this bug. |
shyunMin
pushed a commit
to shyunMin/Xamarin.Forms
that referenced
this pull request
Dec 11, 2020
* Fix CarouselView page size * Fix CarouselView position update time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Proposing this as an alternative to PR 444
PR 444 is adding a Platform Specific to NavigationPage which allows the developer to disable the default Android state loss check when committing a fragment transaction.
The state loss check prevents unexpected behavior when restoring the state of fragments upon resuming an application. However, XF doesn't support fragment restoration at this time. So rather than add another Platform Specific which we have to maintain, we can simply change from
Commit()toCommitAllowingStateLoss().This PR also addresses a similar issue with MasterDetailPage, which also utilizes fragments (and thus transactions) when setting the master to detail to a NavigationPage or TabbedPage.