New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CommitAllowingStateLoss the default for FragmentTransactions #527

Merged
merged 1 commit into from Nov 16, 2016

Conversation

Projects
None yet
9 participants
@hartez
Member

hartez commented Nov 14, 2016

Description of Change

Proposing this as an alternative to PR 444

PR 444 is adding a Platform Specific to NavigationPage which allows the developer to disable the default Android state loss check when committing a fragment transaction.

The state loss check prevents unexpected behavior when restoring the state of fragments upon resuming an application. However, XF doesn't support fragment restoration at this time. So rather than add another Platform Specific which we have to maintain, we can simply change from Commit() to CommitAllowingStateLoss().

This PR also addresses a similar issue with MasterDetailPage, which also utilizes fragments (and thus transactions) when setting the master to detail to a NavigationPage or TabbedPage.

@adrianknight89

This comment has been minimized.

Show comment
Hide comment
@adrianknight89

adrianknight89 Nov 14, 2016

Contributor

I'm okay with this in favor of the other PR.

Contributor

adrianknight89 commented Nov 14, 2016

I'm okay with this in favor of the other PR.

@jassmith jassmith merged commit 243d9e0 into master Nov 16, 2016

3 of 4 checks passed

iOS10-UITests Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Tests failed: 18…
Details
Android-UITests Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Tests passed: 351, i…
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 9 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle9 (EZ Test) :: Windows Debug : Tests passed: 3461, ignored: 8
Details
@adrianknight89

This comment has been minimized.

Show comment
Hide comment
@adrianknight89
Contributor

adrianknight89 commented Nov 24, 2016

@adrianknight89

This comment has been minimized.

Show comment
Hide comment
Contributor

adrianknight89 commented Nov 24, 2016

@adrianknight89

This comment has been minimized.

Show comment
Hide comment
@adrianknight89
Contributor

adrianknight89 commented Nov 26, 2016

Another possibly related issue: https://bugzilla.xamarin.com/show_bug.cgi?id=42815

@adrianknight89

This comment has been minimized.

Show comment
Hide comment
@shnaz

This comment has been minimized.

Show comment
Hide comment
@shnaz

shnaz Jan 11, 2017

Hey @adrianknight89, any idea when this fix gonna hit the road?

shnaz commented Jan 11, 2017

Hey @adrianknight89, any idea when this fix gonna hit the road?

@adrianknight89

This comment has been minimized.

Show comment
Hide comment
@adrianknight89

adrianknight89 Jan 11, 2017

Contributor

I'm not 100% sure, but I'd wait for 2.3.4-pre2. Hopefully later this month or early next month.

Contributor

adrianknight89 commented Jan 11, 2017

I'm not 100% sure, but I'd wait for 2.3.4-pre2. Hopefully later this month or early next month.

@stefandevo

This comment has been minimized.

Show comment
Hide comment
@stefandevo

stefandevo Jan 16, 2017

Contributor

Can you confirm it is NOT released in 2.3.4-pre1 then?

Contributor

stefandevo commented Jan 16, 2017

Can you confirm it is NOT released in 2.3.4-pre1 then?

@rmarinho

This comment has been minimized.

Show comment
Hide comment
@rmarinho

rmarinho Jan 16, 2017

Member

@stefandevo it was shipped in 2.3.4-pre1 , we were going to call it 2.3.4-pre2 but it was shipped last week as pre1

Member

rmarinho commented Jan 16, 2017

@stefandevo it was shipped in 2.3.4-pre1 , we were going to call it 2.3.4-pre2 but it was shipped last week as pre1

@owlstack

This comment has been minimized.

Show comment
Hide comment
@owlstack

owlstack Jan 19, 2017

What stable release version will this be in then? Thanks! I thought it would be in 2.3.3.180

owlstack commented Jan 19, 2017

What stable release version will this be in then? Thanks! I thought it would be in 2.3.3.180

@shnaz

This comment has been minimized.

Show comment
Hide comment
@shnaz

shnaz Jan 19, 2017

Yes please, our users are heavily affected by this bug.

shnaz commented Jan 19, 2017

Yes please, our users are heavily affected by this bug.

@hartez hartez deleted the android-fragmenttransaction-commit branch May 16, 2017

@samhouts samhouts added this to the 2.3.4 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment