[iOS] Labels with WordWrap or CharacterWrap will Expand #529

Merged
merged 3 commits into from Jan 12, 2017

Conversation

Projects
None yet
6 participants
@samhouts
Member

samhouts commented Nov 15, 2016

Description of Change

iOS LabelRenderer will now expand the width of the Label to the width constraint if the Label's LineBreakMode is set to WordWrap (default) or CharacterWrap.

Bugs Fixed

API Changes

None

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@rmarinho

This comment has been minimized.

Show comment
Hide comment
@rmarinho

rmarinho Jan 3, 2017

Member

Can you rebase this @samhouts thanks.

Member

rmarinho commented Jan 3, 2017

Can you rebase this @samhouts thanks.

samhouts added some commits Nov 15, 2016

[iOS] Expand the label to fill width if wrapping
Also, simplify the `if` statement, since `LineBreakMode` is not a flags
enum and the only excluded member was `None`.

@samhouts samhouts requested a review from jassmith Jan 4, 2017

@samhouts samhouts assigned samhouts and jassmith and unassigned samhouts Jan 5, 2017

@jassmith jassmith removed the waiting-tests label Jan 12, 2017

@jassmith jassmith merged commit 3af99cb into master Jan 12, 2017

6 checks passed

Android-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Tests passed: 352, i…
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: Windows Debug : Tests passed: 3695, ignored: 10
Details
iOS10-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Tests passed: 34…
Details
iOS8-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified IOS8 : Tests passed: 345…
Details
iOS9-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Tests passed: 347…
Details
@escamoteur

This comment has been minimized.

Show comment
Hide comment
@escamoteur

escamoteur Mar 1, 2017

Is this already in any release?

Is this already in any release?

@samhouts

This comment has been minimized.

Show comment
Hide comment
@samhouts

samhouts Mar 1, 2017

Member

@escamoteur It is in the latest prerelease (2.3.4) and in the latest nightly build.

Member

samhouts commented Mar 1, 2017

@escamoteur It is in the latest prerelease (2.3.4) and in the latest nightly build.

@samhouts samhouts deleted the fix-bugzilla28650 branch Mar 1, 2017

@escamoteur

This comment has been minimized.

Show comment
Hide comment
@escamoteur

escamoteur Mar 1, 2017

Thanks, it turns out that the real reason is the problem that the OnAppearing Event on iOS still comes too late for the RxUI Bindings with Xaml bindings it works

see
https://forums.xamarin.com/discussion/84510/proposal-improved-life-cycle-support

Thanks, it turns out that the real reason is the problem that the OnAppearing Event on iOS still comes too late for the RxUI Bindings with Xaml bindings it works

see
https://forums.xamarin.com/discussion/84510/proposal-improved-life-cycle-support

@samhouts samhouts referenced this pull request Mar 20, 2017

Merged

[iOS/Win] Label will not unnecessarily expand #827

4 of 4 tasks complete

@samhouts samhouts added this to the 2.3.4 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment