New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Do not show cell context actions if input views are long clicked #544

Merged
merged 2 commits into from Nov 18, 2016

Conversation

Projects
None yet
5 participants
@adrianknight89
Contributor

adrianknight89 commented Nov 18, 2016

Description of Change

Input views do not trap long clicks to show their editor context menus. Instead, cell context actions are shown. Please let me know if this needs to be a platform specific option or default expected behavior.

P.S. There seems to be an issue with SearchBar not getting focus when placed in a cell. When testing the sample code, make sure to give focus to other input views before long clicking SearchBar. There should be another bug for this.

Bugs Fixed

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@jassmith

This comment has been minimized.

Show comment
Hide comment
@jassmith

jassmith Nov 18, 2016

Member

👍 looks good

Member

jassmith commented Nov 18, 2016

👍 looks good

@rmarinho rmarinho merged commit 4cb6e6d into xamarin:master Nov 18, 2016

@samhouts samhouts added this to the 2.3.4 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment