Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XamlC] Fix message for unresolved event handler reference in DataTemplate #5502

Merged
merged 1 commit into from Mar 11, 2019

Conversation

@akihikodaki
Copy link
Contributor

akihikodaki commented Mar 8, 2019

Description of Change

Fix message for unresolved event handler reference in DataTemplate. The old implementation mistakenly showed an anonymous type for the delegate which confused my colleague and wasted his time 馃槀 .

Issues Resolved

None

API Changes

None

Platforms Affected

  • Core/XAML (all platforms)

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

PR Checklist

  • Has automated tests The output is not tested because it is a free-form natural language text.
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard
@akihikodaki akihikodaki requested a review from StephaneDelcroix as a code owner Mar 8, 2019
@StephaneDelcroix StephaneDelcroix merged commit b5c8345 into xamarin:master Mar 11, 2019
1 check passed
1 check passed
license/cla All CLA requirements met.
@samhouts samhouts added this to Done in v4.1.0 Mar 11, 2019
adrianknight89 added a commit to adrianknight89/Xamarin.Forms that referenced this pull request Mar 29, 2019
codemillmatt added a commit to codemillmatt/Xamarin.Forms that referenced this pull request Apr 19, 2019
@samhouts samhouts added this to Done in v4.2.0 May 29, 2019
@samhouts samhouts removed this from Done in v4.1.0 May 29, 2019
@samhouts samhouts added this to the 4.1.0 milestone Jun 4, 2019
@samhouts samhouts removed this from Done in v4.2.0 Jun 4, 2019
@samhouts samhouts added this to Done in v4.1.0 Jun 4, 2019
AxelUser added a commit to AxelUser/Xamarin.Forms that referenced this pull request Jun 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v4.1.0
  
Done
3 participants
You can鈥檛 perform that action at this time.