Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mac] disregard the Dark mode #5537

Merged
merged 1 commit into from Mar 18, 2019

Conversation

@paymicro
Copy link
Contributor

paymicro commented Mar 13, 2019

Description of Change

The application usable in dark mode.

Issues Resolved

API Changes

None

Platforms Affected

Mac

Behavioral/Visual Changes

The application will never go to the dark side.

Before/After Screenshots

Before
image

After
image

Testing Procedure

  • run Control Gallery in Dark mode

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard
@samhouts samhouts added this to In Review in v4.1.0 Mar 13, 2019
@paymicro paymicro requested a review from rmarinho Mar 14, 2019
@rmarinho rmarinho merged commit 21eb50b into master Mar 18, 2019
13 of 15 checks passed
13 of 15 checks passed
Xamarin Forms Yaml Build #PR-5537 - (2492433) has failed
Details
Xamarin Forms Yaml (OSX Phase) OSX Phase failed
Details
Xamarin Forms Build #PR-5537 - (2505628) succeeded
Details
Xamarin Forms (Build Windows Phase Debug,any cpu) Build Windows Phase Debug,any cpu succeeded
Details
Xamarin Forms (Nuget Phase) Nuget Phase succeeded
Details
Xamarin Forms (OSX Phase) OSX Phase succeeded
Details
Xamarin Forms (Prepare Build Phase) Prepare Build Phase succeeded
Details
Xamarin Forms (Test Phase debug) Test Phase debug succeeded
Details
Xamarin Forms Yaml (Build Windows Phase Release) Build Windows Phase Release succeeded
Details
Xamarin Forms Yaml (Build Windows Phase debug) Build Windows Phase debug succeeded
Details
Xamarin Forms Yaml (Nuget Phase) Nuget Phase succeeded
Details
Xamarin Forms Yaml (Prepare Build Phase) Prepare Build Phase succeeded
Details
Xamarin Forms Yaml (Test Windows Phase Release) Test Windows Phase Release succeeded
Details
Xamarin Forms Yaml (Test Windows Phase debug) Test Windows Phase debug succeeded
Details
license/cla All CLA requirements met.
v4.1.0 automation moved this from In Review to Done Mar 18, 2019
@paymicro paymicro deleted the paymicro/fix-gh3777-mac-dark branch Mar 29, 2019
adrianknight89 added a commit to adrianknight89/Xamarin.Forms that referenced this pull request Mar 29, 2019
codemillmatt added a commit to codemillmatt/Xamarin.Forms that referenced this pull request Apr 19, 2019
@samhouts samhouts added this to Done in v4.2.0 May 29, 2019
@samhouts samhouts removed this from Done in v4.1.0 May 29, 2019
@samhouts samhouts added this to the 4.1.0 milestone Jun 4, 2019
@samhouts samhouts removed this from Done in v4.2.0 Jun 4, 2019
@samhouts samhouts added this to Done in v4.1.0 Jun 4, 2019
AxelUser added a commit to AxelUser/Xamarin.Forms that referenced this pull request Jun 15, 2019
@samhouts samhouts added the p/iOS 🍎 label Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v4.1.0
  
Done
3 participants
You can’t perform that action at this time.