Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispose FrameRenderer's FrameDrawable #5617

Merged
merged 1 commit into from Mar 27, 2019
Merged

Dispose FrameRenderer's FrameDrawable #5617

merged 1 commit into from Mar 27, 2019

Conversation

@kingces95
Copy link
Member

kingces95 commented Mar 19, 2019

Description of Change

Dispose FrameRenderer's FrameDrawable.

Issues Resolved

API Changes

None

Platforms Affected

  • Android

Behavioral/Visual Changes

None; Doesn't crash due to OOM.

Before/After Screenshots

Not applicable

Testing Procedure

Run reproduction in fixed issue.

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard
@hartez
hartez approved these changes Mar 22, 2019
@rmarinho rmarinho merged commit afe481b into master Mar 27, 2019
20 of 26 checks passed
20 of 26 checks passed
VSTS: Android API19 Validation Fast Renderers UITests Finished
Details
VSTS: Android API28 Validation Fast Renderers UITests Finished
Details
VSTS: Android API19 Validation Legacy Renderers UITests Running
Details
VSTS: Android API23 Validation Fast Renderers UITests Running
Details
VSTS: Android API23 Validation Legacy Renderers UITests Running
Details
VSTS: Android API25 Validation Fast Renderers UITests Running
Details
VSTS: Android API25 Validation Legacy Renderers UITests Finished
Details
VSTS: Android API28 Validation Legacy Renderers UITests Finished
Details
VSTS: iOS10 Validation UITests Finished
Details
VSTS: iOS11 Validation UITests Finished
Details
VSTS: iOS12 Validation UITests Finished
Details
Xamarin Forms Build #PR-5617 - (2528316) succeeded
Details
Xamarin Forms (Build Windows Phase Debug,any cpu) Build Windows Phase Debug,any cpu succeeded
Details
Xamarin Forms (Nuget Phase) Nuget Phase succeeded
Details
Xamarin Forms (OSX Phase) OSX Phase succeeded
Details
Xamarin Forms (Prepare Build Phase) Prepare Build Phase succeeded
Details
Xamarin Forms (Test Phase debug) Test Phase debug succeeded
Details
Xamarin Forms Yaml Build #PR-5617 - (2511731) succeeded
Details
Xamarin Forms Yaml (Build Windows Phase Release) Build Windows Phase Release succeeded
Details
Xamarin Forms Yaml (Build Windows Phase debug) Build Windows Phase debug succeeded
Details
Xamarin Forms Yaml (Nuget Phase) Nuget Phase succeeded
Details
Xamarin Forms Yaml (OSX Phase) OSX Phase succeeded
Details
Xamarin Forms Yaml (Prepare Build Phase) Prepare Build Phase succeeded
Details
Xamarin Forms Yaml (Test Windows Phase Release) Test Windows Phase Release succeeded
Details
Xamarin Forms Yaml (Test Windows Phase debug) Test Windows Phase debug succeeded
Details
license/cla All CLA requirements met.
v4.1.0 automation moved this from In Review to Done Mar 27, 2019
adrianknight89 added a commit to adrianknight89/Xamarin.Forms that referenced this pull request Mar 29, 2019
codemillmatt added a commit to codemillmatt/Xamarin.Forms that referenced this pull request Apr 19, 2019
@samhouts samhouts added this to Done in v4.2.0 May 29, 2019
@samhouts samhouts removed this from Done in v4.1.0 May 29, 2019
@samhouts samhouts added this to the 4.1.0 milestone Jun 4, 2019
@samhouts samhouts removed this from Done in v4.2.0 Jun 4, 2019
@samhouts samhouts added this to Done in v4.1.0 Jun 4, 2019
AxelUser added a commit to AxelUser/Xamarin.Forms that referenced this pull request Jun 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v4.1.0
  
Done
5 participants
You can’t perform that action at this time.