New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XamlC] support non-generic IMarkup on ABPs #562

Merged
merged 2 commits into from Dec 1, 2016

Conversation

Projects
None yet
4 participants
@StephaneDelcroix
Member

StephaneDelcroix commented Nov 24, 2016

Description of Change

see the title, there ^^^

note: this might be a slight regression, but implementing IMarkupExtension<T> is a valid workaround

Bugs Fixed

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@StephaneDelcroix StephaneDelcroix changed the title from [XamlC] support custom markups on ABPs to [XamlC] support non-generic IMarkup on ABPs Nov 30, 2016

@@ -94,9 +94,10 @@ public void Visit(ElementNode node, INode parentNode)
var localName = propertyName.LocalName;
TypeReference declaringTypeReference = null;
FieldReference bpRef = null;
var _ = false;

This comment has been minimized.

@rmarinho

rmarinho Nov 30, 2016

Member

strange name here.. why this ?

@rmarinho

rmarinho Nov 30, 2016

Member

strange name here.. why this ?

@StephaneDelcroix StephaneDelcroix merged commit 70d29b9 into master Dec 1, 2016

3 of 10 checks passed

Android-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Snapshot dependency …
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: OSX Debug : Exit code 255 (new)
Details
iOS10-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Snapshot depende…
Details
iOS8-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified IOS8 : Snapshot dependen…
Details
iOS9-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Snapshot dependen…
Details
iOS9-UITests-C9 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Tests failed: 2,…
Details
Android-UITests-C9 Started TeamCity Build Xamarin.Forms :: Debug :: Cycle 9 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1
Details
OSX-Debug-C9 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 9 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: Windows Debug : Tests passed: 3589, ignored: 10
Details
Windows-Debug-C9 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 9 :: Windows Debug : Tests passed: 3589, ignored: 10
Details

@StephaneDelcroix StephaneDelcroix deleted the fix-customMarkupOnABP branch Dec 1, 2016

StephaneDelcroix added a commit that referenced this pull request Dec 1, 2016

[XamlC] support non-generic IMarkup on ABPs (#562)
* [XamlC] support custom markups on ABPs

* [XamlC] test for 47950

jonathanpeppers pushed a commit to Hitcents/Xamarin.Forms that referenced this pull request Jan 26, 2017

jonathanpeppers pushed a commit to Hitcents/Xamarin.Forms that referenced this pull request Jan 26, 2017

@samhouts samhouts modified the milestones: 2.3.4, 2.3.3 Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment