New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XamlC] Type ref tests, and fixes #569

Merged
merged 3 commits into from Dec 7, 2016

Conversation

Projects
None yet
4 participants
@StephaneDelcroix
Member

StephaneDelcroix commented Nov 28, 2016

Description of Change

Test and fixes for TypeReferenceExtensions.

This is a more complete fix than #566, but because of the new exception being thrown, I do not feel confident about including this in a bug fix release.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@StephaneDelcroix StephaneDelcroix changed the title from Type ref tests, and fixes to [XamlC] Type ref tests, and fixes Nov 28, 2016

@StephaneDelcroix StephaneDelcroix merged commit 8181e6d into master Dec 7, 2016

2 of 3 checks passed

iOS10-UITests-C8 Started TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: Windows Debug : Tests passed: 3675, ignored: 10
Details

@StephaneDelcroix StephaneDelcroix deleted the typeRefTests branch Dec 7, 2016

@samhouts samhouts added this to the 2.3.4 milestone Jul 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment