Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow EmptyView swapping in Android CollectionView #5720

Merged
merged 5 commits into from Apr 3, 2019

Conversation

@hartez
Copy link
Member

commented Mar 27, 2019

Description of Change

Prevent crash when displaying EmptyView on Android.
Update EmptyViewAdapter to create a new ViewHolder when the EmptyView or EmptyViewTemplate properties change.

Also adds an automated test for this behavior.

Issues Resolved

API Changes

None

Platforms Affected

  • Android

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard

@samhouts samhouts requested a review from rmarinho Mar 27, 2019

@samhouts samhouts added this to In Review in vCurrent (4.0.0) Mar 27, 2019

@samhouts samhouts requested a review from PureWeen Mar 27, 2019

@rmarinho
Copy link
Member

left a comment

Crashing on iOS when navigation to the issue page , works fine on Android

@samhouts samhouts moved this from In Review to In Progress in vCurrent (4.0.0) Mar 27, 2019

@samhouts samhouts requested a review from rmarinho Mar 27, 2019

hartez added some commits Mar 27, 2019

@hartez hartez force-pushed the fix-gh5535 branch from 8ae55b6 to ef0319b Mar 28, 2019

@PureWeen
Copy link
Contributor

left a comment

I can't get the android one to filter
API 23

image

@rmarinho rmarinho merged commit d1dc874 into 4.0.0 Apr 3, 2019

25 of 30 checks passed

VSTS: Android API23 Validation Fast Renderers UITests Finished
Details
VSTS: Android API23 Validation Legacy Renderers UITests Finished
Details
VSTS: Android API28 Validation Fast Renderers UITests Finished
Details
VSTS: iOS12 Validation UITests Finished
Details
VSTS: Android API25 Validation Fast Renderers UITests Running
Details
VSTS: Android API19 Validation Fast Renderers UITests Finished
Details
VSTS: Android API19 Validation Legacy Renderers UITests Finished
Details
VSTS: Android API25 Validation Legacy Renderers UITests Finished
Details
VSTS: Android API28 Validation Legacy Renderers UITests Finished
Details
VSTS: iOS10 Validation UITests Finished
Details
VSTS: iOS11 Validation UITests Finished
Details
Xamarin Forms Build #PR-5720 - (2549955) succeeded
Details
Xamarin Forms (Build Windows Phase Debug,any cpu) Build Windows Phase Debug,any cpu succeeded
Details
Xamarin Forms (Nuget Phase) Nuget Phase succeeded
Details
Xamarin Forms (OSX Phase) OSX Phase succeeded
Details
Xamarin Forms (Prepare Build Phase) Prepare Build Phase succeeded
Details
Xamarin Forms (Test Phase debug) Test Phase debug succeeded
Details
Xamarin Forms Yaml Build #PR-5720 - (2540046) succeeded
Details
Xamarin Forms Yaml (Build Android [Fast Renderers]) Build Android [Fast Renderers] succeeded
Details
Xamarin Forms Yaml (Build Android [Legacy Renderers]) Build Android [Legacy Renderers] succeeded
Details
Xamarin Forms Yaml (Build Android [Pre-AppCompat]) Build Android [Pre-AppCompat] succeeded
Details
Xamarin Forms Yaml (Build Windows Phase Release) Build Windows Phase Release succeeded
Details
Xamarin Forms Yaml (Build Windows Phase debug) Build Windows Phase debug succeeded
Details
Xamarin Forms Yaml (Nuget Phase) Nuget Phase succeeded
Details
Xamarin Forms Yaml (OSX Phase) OSX Phase succeeded
Details
Xamarin Forms Yaml (Prepare Build Phase) Prepare Build Phase succeeded
Details
Xamarin Forms Yaml (Sign Phase) Sign Phase succeeded
Details
Xamarin Forms Yaml (Test Windows Phase Release) Test Windows Phase Release succeeded
Details
Xamarin Forms Yaml (Test Windows Phase debug) Test Windows Phase debug succeeded
Details
license/cla All CLA requirements met.
Details

vCurrent (4.0.0) automation moved this from In Progress to Done Apr 3, 2019

@samhouts samhouts added this to the 4.0.0 milestone Apr 10, 2019

@samhouts samhouts added the t/bug 🐛 label Jun 6, 2019

AxelUser added a commit to AxelUser/Xamarin.Forms that referenced this pull request Jun 15, 2019

Allow EmptyView swapping in Android CollectionView (xamarin#5720) fixes
xamarin#5535

* Automated test for issue

* Fix empty view swapping for Android (fixes xamarin#5535)

* Remove private modifier

* Account for null Flags when setting flags for test

* Fix rebase issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.