New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XamlC] provide backward compat for ProvideValueTarget without Target… #583

Merged
merged 2 commits into from Dec 1, 2016

Conversation

Projects
None yet
5 participants
@StephaneDelcroix
Member

StephaneDelcroix commented Nov 30, 2016

Description of Change

[XamlC] provide backward compat for ProvideValueTarget without TargetProperty

Bugs Fixed

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
if (Key == null)
{
var lineInfoProvider = serviceProvider.GetService(typeof (IXmlLineInfoProvider)) as IXmlLineInfoProvider;
if (Key == null) {

This comment has been minimized.

@activa

activa Nov 30, 2016

Contributor

Isn't the curly brace supposed to be on the next line?

@activa

Coding style should be consistent. Braces should be placed on a line by itself: https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/coding-style.md

@StephaneDelcroix StephaneDelcroix merged commit 3ff3487 into master Dec 1, 2016

@StephaneDelcroix StephaneDelcroix deleted the fix-48105 branch Dec 1, 2016

@activa

This comment has been minimized.

Contributor

activa commented Dec 1, 2016

So what about coding style?

StephaneDelcroix added a commit that referenced this pull request Dec 1, 2016

[XamlC] provide backward compat for ProvideValueTarget without Target… (
#583)

* [XamlC] provide backward compat for ProvideValueTarget without TargetProperty

* docs
@@ -137,6 +137,11 @@ public class SimpleValueTargetProvider : IProvideParentValues, IProvideValueTarg
readonly object[] objectAndParents;
readonly object targetProperty;
[Obsolete("TargetProperty is now supported, use it")]

This comment has been minimized.

@ahmedalejo

jonathanpeppers pushed a commit to Hitcents/Xamarin.Forms that referenced this pull request Jan 26, 2017

@samhouts samhouts modified the milestones: 2.3.4, 2.3.3 Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment