[XamlC] drop ICSharpCode.Decompiler #586

Merged
merged 3 commits into from Dec 5, 2016

Conversation

Projects
None yet
4 participants
@StephaneDelcroix
Member

StephaneDelcroix commented Dec 1, 2016

Description of Change

Drop the decompiler. it was there to help debugging XamlC at its beginning, but shipping a decompiler is not our mission, and anyone can use a 3rd party one.

The choice of decompiler on windows is large. On Mac, not that much. You can use this one https://github.com/StephaneDelcroix/Sdx.Decompiler, that's the one I'm using from now on.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@samhouts

Need to remember to list this as a breaking change.

Xamarin.Forms.Build.Tasks/XamlCTask.cs
- codeDomBuilder.GenerateCode(output);
- }
+ if (outputGeneratedILAsCode)
+ Logger.LogLine(2, " Decompiling option has been removed. Use a 3rd party decompiler to admire the beauty fo the IL generated");

This comment has been minimized.

@samhouts

samhouts Dec 2, 2016

Member

Typo. fo instead of of

@samhouts

samhouts Dec 2, 2016

Member

Typo. fo instead of of

@StephaneDelcroix StephaneDelcroix merged commit 1a5bead into master Dec 5, 2016

1 of 5 checks passed

Android-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Snapshot dependency …
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: OSX Debug : Snapshot dependency failed to start: ... Windows Debug
Details
iOS10-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Snapshot depende…
Details
iOS9-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Snapshot dependen…
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: Windows Debug : Tests passed: 3585, ignored: 10
Details

@StephaneDelcroix StephaneDelcroix deleted the dropDecompiler branch Dec 5, 2016

@samhouts samhouts added this to the 2.3.4 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment