Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Fix usage of iOS11 api #5893

Merged
merged 2 commits into from Apr 15, 2019

Conversation

2 participants
@rmarinho
Copy link
Member

rmarinho commented Apr 11, 2019

Description of Change

Don't call iOS11 APIs on iOS10 or lower.

Issues Resolved

  • None

API Changes

None

Platforms Affected

  • iOS

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

Should fix iOS10 UITests

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard
@samhouts

This comment has been minimized.

Copy link
Member

samhouts commented Apr 13, 2019

@rmarinho Still failing on iOS10 :(

@samhouts

This comment has been minimized.

Copy link
Member

samhouts commented Apr 15, 2019

Failing tests not related!

@samhouts samhouts merged commit 4f0724f into 4.0.0 Apr 15, 2019

7 of 9 checks passed

VSTS: iOS10 Validation UITests Finished
Details
VSTS: iOS12 Validation UITests Finished
Details
VSTS: Android API19 Validation Fast Renderers UITests Finished
Details
VSTS: Android API23 Validation Fast Renderers UITests Finished
Details
VSTS: Android API25 Validation Fast Renderers UITests Finished
Details
VSTS: Android API28 Validation Fast Renderers UITests Finished
Details
VSTS: Android API28 Validation Legacy Renderers UITests Finished
Details
VSTS: iOS11 Validation UITests Finished
Details
license/cla All CLA requirements met.
Details

@samhouts samhouts deleted the fix-ios10home branch Apr 15, 2019

@samhouts samhouts added this to Done in vNext (4.0.0) Apr 15, 2019

@samhouts samhouts added this to the 4.0.0 milestone Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.