Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s/SearchBoxVisiblity/SearchBoxVisibility/ #5925

Closed
wants to merge 4 commits into from

Conversation

@lobrien
Copy link
Contributor

lobrien commented Apr 16, 2019

Fix typo in type name.

Description of Change

I searched for the string SearchBoxVisiblity and changed it to SearchBoxVisibility.

Issues Resolved

API Changes

Xamarin.Forms.Controls.XamStore.AddSearchHandler(string,SearchBoxVisiblty) -> changed arg type
enum SearchBoxVisiblity -> SearchBoxVisibility

Platforms Affected

  • Core/XAML (all platforms)

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

Build
Build Xamarin.Forms.Core.UnitTests
Run Unit Tests.

4 unit tests fail:
ListProxyTests.WeakToWeak
MapTests.ElementIsGarbageCollectedAfterItsRemoved
MessagingCenterTests.SubscriberCollectableAfterUnsubscribeEvenIfHeldByClosure
ShellUriHandlerTests.SubscriberCollectableAfterUnsubscribeEvenIfHeldByClosure

I don't think any of those failures plausibly relate to this change

PR Checklist

  • Has automated tests

No additional tests because renaming enum. If old symbol used, should not compile. Even if reflection, "Replace in files..." should have caught string

  • [ x ] Rebased on top of the target branch at time of PR
  • [ x ] Changes adhere to coding standard
s/SearchBoxVisiblty/SearchBoxVisibility/
Fix typo in type name.

@lobrien lobrien requested a review from StephaneDelcroix as a code owner Apr 16, 2019

@dnfclas

This comment has been minimized.

Copy link

dnfclas commented Apr 16, 2019

CLA assistant check
All CLA requirements met.

@lobrien lobrien changed the title s/SearchBoxVisiblty/SearchBoxVisibility/ s/SearchBoxVisiblity/SearchBoxVisibility/ Apr 16, 2019

@samhouts
Copy link
Member

samhouts left a comment

🤦‍♀️

@@ -11,7 +11,7 @@ public class ButtonGallery : ContentPage
public ButtonGallery ()
{
//ShellAppearance.SetNavBarVisible(this, false);
Shell.SetSearchHandler(this, new SearchHandler() { SearchBoxVisibility = SearchBoxVisiblity.Collapsable });
Shell.SetSearchHandler(this, new SearchHandler() { SearchBoxVisibility = SearchBoxVisibility.Collapsable });

This comment has been minimized.

Copy link
@samhouts

samhouts Apr 16, 2019

Member

as long as we're in here....

Suggested change
Shell.SetSearchHandler(this, new SearchHandler() { SearchBoxVisibility = SearchBoxVisibility.Collapsable });
Shell.SetSearchHandler(this, new SearchHandler() { SearchBoxVisibility = SearchBoxVisibility.Collapsible });
@StephaneDelcroix

This comment has been minimized.

Copy link
Member

StephaneDelcroix commented Apr 16, 2019

could you please retarget this to 4.0.0 ?

@samhouts this is a breaking change, but on unreleased API. so I'm fine

@StephaneDelcroix
Copy link
Member

StephaneDelcroix left a comment

🤦‍♂️

@lobrien lobrien changed the base branch from master to 4.0.0 Apr 16, 2019

@lobrien lobrien changed the base branch from 4.0.0 to master Apr 16, 2019

@lobrien lobrien changed the base branch from master to 4.0.0 Apr 16, 2019

@samhouts samhouts added this to In Progress in vNext+1 (master) Apr 16, 2019

@lobrien lobrien force-pushed the lobrien:lobrien_fix_visibility_typo branch from e4b696c to d6b318a Apr 16, 2019

@lobrien lobrien changed the base branch from 4.0.0 to master Apr 16, 2019

@samhouts samhouts closed this Apr 16, 2019

vNext+1 (master) automation moved this from In Progress to Closed Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.